Skip to content

fix: Use user locale for sending password resets#10104

Merged
zomars merged 1 commit intomainfrom
bugfix/password-reset-email-user-locale
Jul 12, 2023
Merged

fix: Use user locale for sending password resets#10104
zomars merged 1 commit intomainfrom
bugfix/password-reset-email-user-locale

Conversation

@emrysal
Copy link
Copy Markdown
Contributor

@emrysal emrysal commented Jul 12, 2023

What does this PR do?

Instead of passing through the browser locale it makes more sense of sending the email according to the locale configured by the user.

@emrysal emrysal requested a review from a team July 12, 2023 17:56
@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 6:00pm
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 6:00pm
cal-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 6:00pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 6:00pm

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Jul 12, 2023

🤖 Meticulous spotted visual differences in 36 of 181 screens tested: view and approve differences detected.

Last updated for commit 476dd1c. This comment will update as new commits are pushed.

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jul 12, 2023

Current Playwright Test Results Summary

✅ 88 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/12/2023 06:08:36pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 476dd1c

Started: 07/12/2023 06:04:18pm UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
2.70% (1) 1 / 37 run
failed over last 7 days
97.30% (36) 36 / 37 runs
flaked over last 7 days

View Detailed Build Results


@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zomars zomars merged commit 3009f17 into main Jul 12, 2023
@zomars zomars deleted the bugfix/password-reset-email-user-locale branch July 12, 2023 19:04
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants