fix: onboard-pricing-options-self-host by alannnc · Pull Request #10105 · calcom/cal.diy

alannnc · 2023-07-12T17:58:20Z

What does this PR do?

Change $99 plan with a link to contact sales page.

Fixes #10075

Requirement/Documentation

Type of change

Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

Are there environment variables that should be set? No.
What are the minimal test data to have? DB without any user admin created.
What is expected (happy path) to have (input and output)?
Button should redirect to cal.com/sales pages instead of being selectable.
Any other important info that could help to test that PR
Modifying/Commenting code on the SSR function that returns 404 when an user admin exist on the DB on auth/index so auth/setup doesn't return 404

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

I haven't added tests that prove my fix is effective or that my feature works

vercel · 2023-07-12T17:58:27Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 12, 2023 7:25pm
cal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 12, 2023 7:25pm
cal-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 12, 2023 7:25pm
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 12, 2023 7:25pm

alannnc · 2023-07-12T17:58:32Z


 import { useLocale } from "@calcom/lib/hooks/useLocale";

-const ENTERPRISE_BOOKING_FEE = "$99"; // TODO: get this from a new API endpoint


No longer needed

github-actions · 2023-07-12T17:58:36Z

Thank you for following the naming conventions! 🙏

alannnc · 2023-07-12T17:58:44Z

            </ul>
          </div>
        </RadioGroup.Item>
-        <RadioGroup.Item value="EE">


Disabled and now as a Link

shirazdole · 2023-07-12T18:00:34Z

Is there a screenshot to see the new panel?

alwaysmeticulous · 2023-07-12T18:04:21Z

🤖 Meticulous spotted visual differences in 41 of 158 screens tested: view and approve differences detected.

_{Last updated for commit 965bc9f. This comment will update as new commits are pushed.}

deploysentinel · 2023-07-12T18:11:07Z

Current Playwright Test Results Summary

✅ 88 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/12/2023 07:29:19pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 965bc9f

Started: 07/12/2023 07:26:52pm UTC

⚠️ Flakes

📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download Retry 2 • Retry 1 • Initial Attempt	2.76% (6) 6 / 217 runs failed over last 7 days	43.32% (94) 94 / 217 runs flaked over last 7 days

📄 apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
pro user can book with multiple guests Retry 1 • Initial Attempt	0% (0) 0 / 67 runs failed over last 7 days	1.49% (1) 1 / 67 run flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	2.56% (1) 1 / 39 run failed over last 7 days	97.44% (38) 38 / 39 runs flaked over last 7 days
Popup Tests should open Routing Forms embed on click Retry 1 • Initial Attempt	0% (0) 0 / 39 runs failed over last 7 days	15.38% (6) 6 / 39 runs flaked over last 7 days

📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA Retry 1 • Initial Attempt	0% (0) 0 / 332 runs failed over last 7 days	4.82% (16) 16 / 332 runs flaked over last 7 days

View Detailed Build Results

zomars

github-actions · 2023-07-12T19:05:37Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

alannnc · 2023-07-12T19:15:54Z

Is there a screenshot to see the new panel?

On the PR description

Change ee plan to contact sales link

b643594

github-actions Bot added Medium priority Created by Linear-GitHub Sync self-hosting ✨ feature New feature or request labels Jul 12, 2023

alannnc commented Jul 12, 2023

View reviewed changes

zomars added the core area: core, team members only label Jul 12, 2023

alannnc commented Jul 12, 2023

View reviewed changes

alannnc requested a review from shirazdole July 12, 2023 17:58

vercel Bot deployed to Preview – api July 12, 2023 17:59 View deployment

vercel Bot deployed to Preview – cal-staging July 12, 2023 18:00 View deployment

vercel Bot deployed to Preview – cal July 12, 2023 18:04 View deployment

alannnc added 2 commits July 12, 2023 11:15

Add translations and new design

1df685c

Fix text in sub title

dd1f4a2

alannnc requested review from pumfleet and zomars July 12, 2023 18:26

Merge branch 'main' into fix-onboard-for-self-hosters-pricing-options

9e50a60

vercel Bot deployed to Preview – ui July 12, 2023 18:30 View deployment

vercel Bot deployed to Preview – cal-staging July 12, 2023 18:33 View deployment

vercel Bot deployed to Preview – api July 12, 2023 18:34 View deployment

vercel Bot deployed to Preview – cal July 12, 2023 18:37 View deployment

zomars approved these changes Jul 12, 2023

View reviewed changes

zomars enabled auto-merge (squash) July 12, 2023 19:03

Merge branch 'main' into fix-onboard-for-self-hosters-pricing-options

965bc9f

vercel Bot deployed to Preview – ui July 12, 2023 19:19 View deployment

vercel Bot deployed to Preview – cal-staging July 12, 2023 19:20 View deployment

vercel Bot deployed to Preview – api July 12, 2023 19:20 View deployment

vercel Bot deployed to Preview – cal July 12, 2023 19:25 View deployment

zomars merged commit 496b03e into main Jul 12, 2023

zomars deleted the fix-onboard-for-self-hosters-pricing-options branch July 12, 2023 20:20

keithwillcode added Urgent Created by Linear-GitHub Sync and removed Medium priority Created by Linear-GitHub Sync labels Jul 14, 2023

fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023

fix: onboard-pricing-options-self-host (calcom#10105)

fe09fd2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: onboard-pricing-options-self-host#10105

fix: onboard-pricing-options-self-host#10105
zomars merged 5 commits intomainfrom
fix-onboard-for-self-hosters-pricing-options

alannnc commented Jul 12, 2023 •

edited

Loading

Uh oh!

vercel Bot commented Jul 12, 2023 •

edited

Loading

Uh oh!

alannnc Jul 12, 2023

Uh oh!

github-actions Bot commented Jul 12, 2023 •

edited

Loading

Uh oh!

alannnc Jul 12, 2023

Uh oh!

shirazdole commented Jul 12, 2023

Uh oh!

alwaysmeticulous Bot commented Jul 12, 2023 •

edited

Loading

Uh oh!

deploysentinel Bot commented Jul 12, 2023 •

edited

Loading

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Uh oh!

zomars left a comment

Uh oh!

github-actions Bot commented Jul 12, 2023 •

edited

Loading

Uh oh!

alannnc commented Jul 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		import { useLocale } from "@calcom/lib/hooks/useLocale";

		const ENTERPRISE_BOOKING_FEE = "$99"; // TODO: get this from a new API endpoint

Conversation

alannnc commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Requirement/Documentation

Type of change

How should this be tested?

Mandatory Tasks

Checklist

Uh oh!

vercel Bot commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alannnc Jul 12, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alannnc Jul 12, 2023

Choose a reason for hiding this comment

Uh oh!

shirazdole commented Jul 12, 2023

Uh oh!

alwaysmeticulous Bot commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deploysentinel Bot commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Uh oh!

zomars left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

alannnc commented Jul 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alannnc commented Jul 12, 2023 •

edited

Loading

vercel Bot commented Jul 12, 2023 •

edited

Loading

github-actions Bot commented Jul 12, 2023 •

edited

Loading

alwaysmeticulous Bot commented Jul 12, 2023 •

edited

Loading

deploysentinel Bot commented Jul 12, 2023 •

edited

Loading

github-actions Bot commented Jul 12, 2023 •

edited

Loading