Skip to content

fix: incorrect error messsage for invalid login credentials#10117

Merged
emrysal merged 2 commits intocalcom:mainfrom
puru-khedre:fix/incorrect-error-messsage
Jul 13, 2023
Merged

fix: incorrect error messsage for invalid login credentials#10117
emrysal merged 2 commits intocalcom:mainfrom
puru-khedre:fix/incorrect-error-messsage

Conversation

@puru-khedre
Copy link
Copy Markdown
Contributor

What does this PR do?

fixing the incorrect error message displayed on the cal.com login page. The error message is updated to accurately state "Email or password is incorrect" instead of "Username or password is incorrect."

Fixes #10088

Screenshot from 2023-07-13 05-34-09

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 0:09am

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 13, 2023

@puru-khedre is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in 🐛 bug Something isn't working labels Jul 13, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 13, 2023

Thank you for following the naming conventions! 🙏

@puru-khedre puru-khedre changed the title Fix/incorrect error messsage fix: incorrect error messsage for invalid login credentials Jul 13, 2023
Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙏

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@emrysal emrysal enabled auto-merge (squash) July 13, 2023 12:04
@emrysal emrysal merged commit 352a9e2 into calcom:main Jul 13, 2023
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
…0117)

* fir ErrorCode enum

* update incorrect credentails message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in 🐛 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect Error Message for invalid credentials on login page

2 participants