Skip to content

feat: Override any day of the week#10138

Merged
emrysal merged 3 commits intomainfrom
feature/override-any-day
Jul 13, 2023
Merged

feat: Override any day of the week#10138
emrysal merged 3 commits intomainfrom
feature/override-any-day

Conversation

@emrysal
Copy link
Copy Markdown
Contributor

@emrysal emrysal commented Jul 13, 2023

What does this PR do?

Allows overriding any day, even outside of working hours. Default dayRange set to 9-5 when you try to override outside of working hours.

@emrysal emrysal requested a review from a team July 13, 2023 14:24
@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 3:27pm
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 3:27pm
cal-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 3:27pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ui ⬜️ Ignored (Inspect) Visit Preview Jul 13, 2023 3:27pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 13, 2023

Thank you for following the naming conventions! 🙏

@zomars zomars added the core area: core, team members only label Jul 13, 2023
@emrysal emrysal added the bookings area: bookings, availability, timezones, double booking label Jul 13, 2023
@emrysal emrysal added this to the v3.1 milestone Jul 13, 2023
@emrysal emrysal requested a review from CarinaWolli July 13, 2023 14:25
@PeerRich PeerRich added the High priority Created by Linear-GitHub Sync label Jul 13, 2023
@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Jul 13, 2023

🤖 Meticulous spotted visual differences in 33 of 254 screens tested: view and approve differences detected.

Last updated for commit 1420139. This comment will update as new commits are pushed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 13, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jul 13, 2023

Current Playwright Test Results Summary

✅ 71 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/13/2023 03:32:44pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 1420139

Started: 07/13/2023 03:30:06pm UTC

⚠️ Flakes

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Event Types Page open Embed Dialog and choose floating-popup for First Event Type
Retry 1Initial Attempt
0% (0) 0 / 333 runs
failed over last 7 days
7.51% (25) 25 / 333 runs
flaked over last 7 days

View Detailed Build Results


@CarinaWolli
Copy link
Copy Markdown
Member

Getting 9:00-5:00 twice as the default:
Screenshot 2023-07-13 at 11 10 11

If I have an availability like that:
Screenshot 2023-07-13 at 11 11 23

Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix that first: #10138 (comment)

And also, if there are no working hours at all:
Screenshot 2023-07-13 at 11 19 17

Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My requested changed are fixed. Looks good now 👍

@emrysal emrysal enabled auto-merge (squash) July 13, 2023 15:26
@emrysal emrysal merged commit 0bc7d4c into main Jul 13, 2023
@emrysal emrysal deleted the feature/override-any-day branch July 13, 2023 15:33
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
* feat: Override any day of the week

* Having multiple workingHours would duplicate the default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bookings area: bookings, availability, timezones, double booking core area: core, team members only High priority Created by Linear-GitHub Sync

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants