Conversation
PeerRich
added
High priority
zomars
reviewed
Jul 19, 2023
Contributor
zomars
left a comment
zomars
left a comment
There was a problem hiding this comment.
Looking good @sean-brydon Will make some nits before approving 🙏
Comment on lines
+16
to
+18
| await utils.viewer.teams.get.invalidate(); | ||
| await utils.viewer.eventTypes.invalidate(); | ||
| await utils.viewer.organizations.listMembers.invalidate(); |
Contributor
There was a problem hiding this comment.
We can Promise.All instead of cascading here.
Contributor
There was a problem hiding this comment.
We can even skip the await altogether. Shouldn't be blocking.
Comment on lines
+15
to
+20
| async onSuccess() { | ||
| await utils.viewer.teams.get.invalidate(); | ||
| await utils.viewer.eventTypes.invalidate(); | ||
| await utils.viewer.organizations.listMembers.invalidate(); | ||
| showToast(t("success"), "success"); | ||
| }, |
Contributor
There was a problem hiding this comment.
Suggested change
| async onSuccess() { | |
| await utils.viewer.teams.get.invalidate(); | |
| await utils.viewer.eventTypes.invalidate(); | |
| await utils.viewer.organizations.listMembers.invalidate(); | |
| showToast(t("success"), "success"); | |
| }, | |
| onSuccess() { | |
| // We don't need to wait for invalidate to finish | |
| Promise.all([ | |
| utils.viewer.teams.get.invalidate(), | |
| utils.viewer.eventTypes.invalidate(), | |
| utils.viewer.organizations.listMembers.invalidate(), | |
| ]); | |
| showToast(t("success"), "success"); | |
| }, |
Contributor
There was a problem hiding this comment.
Got this visual nitpick while testing
| organizationId: input.orgId, | ||
| }, | ||
| }), | ||
| prisma.verificationToken.deleteMany({ |
Comment on lines
+85
to
+92
| const rowVirtualizer = useVirtual({ | ||
| parentRef: tableContainerRef, | ||
| size: rows.length, | ||
| overscan: 10, | ||
| }); | ||
| const { virtualItems: virtualRows, totalSize } = rowVirtualizer; | ||
| const paddingTop = virtualRows.length > 0 ? virtualRows?.[0]?.start || 0 : 0; | ||
| const paddingBottom = |
Contributor
There was a problem hiding this comment.
This should be a code comment
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
figma: https://www.figma.com/file/ZJNAFHCAq6rnuGRgUFxjzQ/Organizations----New-features?type=design&node-id=4304-330348&mode=design&t=nKonHZpucwxnqwQI-4 (Not all features are in this PR)
loom: https://www.loom.com/share/30e8ef20a5b34a708dca160d8c04ae6f
shoutout @shadcn for the base of this table <3
Member View:
Admin view:
How to test