feat: replaced slack icon with Discord#10193
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@JaideepGuntupalli is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
Low priority
|
Thank you for following the naming conventions! 🙏 |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
| "./components/toast": "./components/toast/index.tsx", | ||
| "./components/icon": "./components/icon/index.ts" | ||
| "./components/icon": "./components/icon/index.ts", | ||
| "./components/icon/Discord": "./components/icon/Discord.tsx" |
There was a problem hiding this comment.
you could have just exported Discord.tsx from icon/inedex.js
There was a problem hiding this comment.
I tried but for some reason it didn't work. The issue was it is trying to export from lucide react
Udit-takkar
left a comment
Udit-takkar
left a comment
There was a problem hiding this comment.
LGTM. Left one comment
| import React, { forwardRef } from "react"; | ||
|
|
||
| export const Discord = forwardRef<SVGSVGElement, React.SVGProps<SVGSVGElement>>(function Discord(props, ref) { | ||
| return ( |
There was a problem hiding this comment.
It could be a static asset in public/discord.svg which is cacheable then. We can then use it as img src and add classes to it.
There was a problem hiding this comment.
hey i will make a follow up PR making these changes
hariombalhara
left a comment
hariombalhara
left a comment
There was a problem hiding this comment.
1 nit change, otherwise good
|
for some reason this PR wont merge, some tests are failing but without reason |
Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
4 participants
What does this PR do?
Abstracted Discord Icon SVG into its file and replaced the slack icon in the dashboard as per the screenshot in the given issue. Also replaced discord svg with its component in the 404 page.
Fixes #10182
Type of change
Mandatory Tasks