fix: Avoid resetting state one every render.#10210
Merged
hariombalhara merged 2 commits intomainfrom Jul 18, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
github-actions
Bot
added
embed
Contributor
|
Thank you for following the naming conventions! 🙏 |
|
🤖 Meticulous spotted visual differences in 50 of 189 screens tested: view and approve differences detected. Last updated for commit 88a0dea. This comment will update as new commits are pushed. |
hariombalhara
commented
Jul 18, 2023
Comment on lines
-885
to
-929
| const isFilteredByOnlyOneItem = | ||
| (filters?.teamIds?.length === 1 || filters?.userIds?.length === 1) && | ||
| data.eventTypeGroups.length === 1; | ||
|
|
||
| return ( | ||
| <> | ||
| {data.eventTypeGroups.length > 1 || isFilteredByOnlyOneItem ? ( | ||
| <> | ||
| {isMobile ? ( | ||
| <MobileTeamsTab eventTypeGroups={data.eventTypeGroups} /> | ||
| ) : ( | ||
| data.eventTypeGroups.map((group: EventTypeGroup, index: number) => ( | ||
| <div className="flex flex-col" key={group.profile.slug}> | ||
| <EventTypeListHeading | ||
| profile={group.profile} | ||
| membershipCount={group.metadata.membershipCount} | ||
| teamId={group.teamId} | ||
| orgSlug={orgBranding?.slug} | ||
| /> | ||
|
|
||
| <EventTypeList | ||
| types={group.eventTypes} | ||
| group={group} | ||
| groupIndex={index} | ||
| readOnly={group.metadata.readOnly} | ||
| /> | ||
| </div> | ||
| )) | ||
| )} | ||
| </> | ||
| ) : ( | ||
| data.eventTypeGroups.length === 1 && ( | ||
| <EventTypeList | ||
| types={data.eventTypeGroups[0].eventTypes} | ||
| group={data.eventTypeGroups[0]} | ||
| groupIndex={0} | ||
| readOnly={data.eventTypeGroups[0].metadata.readOnly} | ||
| /> | ||
| ) | ||
| )} | ||
|
|
||
| {data.eventTypeGroups.length === 0 && <CreateFirstEventTypeView />} | ||
|
|
||
| <EmbedDialog /> | ||
| {router.query.dialog === "duplicate" && <DuplicateDialog />} |
Member
Author
There was a problem hiding this comment.
Moved this to Main component
hariombalhara
force-pushed
the
state-reset-fix
branch
from
269f3a4 to
9645a04
Compare
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 94 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/18/2023 04:41:52pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 88a0dea Started: 07/18/2023 04:38:39pm UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 2 • Retry 1 • Initial Attempt |
14.46% (48)48 / 332 runsfailed over last 7 days |
20.18% (67)67 / 332 runsflaked over last 7 days |
|
2FA Tests should allow a user to disable 2FA
Retry 1 • Initial Attempt |
0% (0)0 / 333 runsfailed over last 7 days |
4.50% (15)15 / 333 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
1.26% (2)2 / 159 runsfailed over last 7 days |
98.11% (156)156 / 159 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
BOOKING_REJECTED can book an event that requires confirmation and then that booking can be rejected by organizer
Retry 1 • Initial Attempt |
0.58% (2)2 / 344 runsfailed over last 7 days |
5.23% (18)18 / 344 runsflaked over last 7 days |
sean-brydon
approved these changes
Jul 18, 2023
Member
sean-brydon
left a comment
sean-brydon
left a comment
There was a problem hiding this comment.
Nice! This was on my todos actually cause i hate withquery :P
Tested and it seems to work fine for me! I think in the future we should spit up loading eventTypes for users and times so we can do them in separate queries. (Not related to this PR at all :P )
shivamklr
reviewed
Jul 19, 2023
Contributor
shivamklr
left a comment
shivamklr
left a comment
There was a problem hiding this comment.
Tested locally, works great.
fritterhoff
pushed a commit
to hm-edu/cal.com
that referenced
this pull request
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10087
Removes usage of withQuery(which is deprecated). withQuery returns new function instance on each call which causes the component to lose it's state on every render.
Before: https://user-images.githubusercontent.com/72548403/252946101-bc1b985a-eced-4d3f-b354-e3ac96ac7bb8.gif
After fix demo
Type of change
How should this be tested?
Mandatory Tasks
Checklist