Skip to content

fix: lint errors introduced in PR#10225#10230

Merged
PeerRich merged 1 commit intomainfrom
fix/lint
Jul 18, 2023
Merged

fix: lint errors introduced in PR#10225#10230
PeerRich merged 1 commit intomainfrom
fix/lint

Conversation

@alishaz-polymath
Copy link
Copy Markdown
Member

What does this PR do?

Fixes lint errors introduced in PR#10225

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

The Github workflow check should be evidence enough

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 3:54pm
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 3:54pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 3:54pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 3:54pm

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@zomars zomars added the core area: core, team members only label Jul 18, 2023
@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Jul 18, 2023

🤖 Meticulous spotted visual differences in 48 of 136 screens tested: view and approve differences detected.

Last updated for commit 1549641. This comment will update as new commits are pushed.

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/getting-started/[[...step]] 409.27 KB 562.78 KB 160.79% (🟡 +0.27%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jul 18, 2023

Current Playwright Test Results Summary

✅ 71 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/18/2023 03:57:48pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 1549641

Started: 07/18/2023 03:55:39pm UTC

⚠️ Flakes

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Event Types Page open Embed Dialog and choose floating-popup for First Event Type
Retry 1Initial Attempt
0% (0) 0 / 336 runs
failed over last 7 days
5.06% (17) 17 / 336 runs
flaked over last 7 days

📄   apps/web/playwright/reschedule.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule Tests Should do a reschedule from user owner
Retry 1Initial Attempt
0.33% (1) 1 / 300 run
failed over last 7 days
11% (33) 33 / 300 runs
flaked over last 7 days

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types tests Can create managed event type
Retry 1Initial Attempt
0.30% (1) 1 / 337 run
failed over last 7 days
16.02% (54) 54 / 337 runs
flaked over last 7 days

View Detailed Build Results


@PeerRich PeerRich merged commit bb4d587 into main Jul 18, 2023
@PeerRich PeerRich deleted the fix/lint branch July 18, 2023 15:58
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants