fix: update list for countries that don't support alphanumeric sender ids#10232
Merged
fix: update list for countries that don't support alphanumeric sender ids#10232
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
CarinaWolli
commented
Jul 18, 2023
| "+216", | ||
| "+90", | ||
| "+256", | ||
| "+971", |
Contributor
|
Thank you for following the naming conventions! 🙏 |
|
🤖 Meticulous spotted visual differences in 64 of 166 screens tested: view and approve differences detected. Last updated for commit 2dc4c6a. This comment will update as new commits are pushed. |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
PeerRich
approved these changes
Jul 18, 2023
Current Playwright Test Results Summary✅ 71 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/18/2023 09:31:00pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 2dc4c6a Started: 07/18/2023 09:28:17pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 2 • Retry 1 • Initial Attempt |
14.53% (50)50 / 344 runsfailed over last 7 days |
20.93% (72)72 / 344 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Can book a paid booking
Retry 1 • Initial Attempt |
2.27% (8)8 / 353 runsfailed over last 7 days |
6.80% (24)24 / 353 runsflaked over last 7 days |
fritterhoff
pushed a commit
to hm-edu/cal.com
that referenced
this pull request
Jul 25, 2023
… ids (calcom#10232) Co-authored-by: CarinaWolli <wollencarina@gmail.com> Co-authored-by: Peer Richelsen <peeroke@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds three missing country codes to the list of countries that don't support alphanumeric sender ids. I compared the whole list from Twilio with our existing noAphanumericSenderIdSupport list.
Type of change