Skip to content

perf: Event-type config page#10238

Merged
PeerRich merged 1 commit intomainfrom
perf/event-type-page
Jul 18, 2023
Merged

perf: Event-type config page#10238
PeerRich merged 1 commit intomainfrom
perf/event-type-page

Conversation

@leog
Copy link
Copy Markdown
Contributor

@leog leog commented Jul 18, 2023

What does this PR do?

Follows some suggestion to reduce re-renders on a couple of high profile components needed for event-type config page to improve performance. One is related to avoid changing children to re-render by componentizing to behave as an atomic block and the other is to avoid relying on objects when passing down properties.

Fixes #9944

Type of change

  • Performance fix (non-breaking change which intends to improve performance)

How should this be tested?

Open an Event Type config page, it should have to process less re-renders, reducing the TTI (time-to-interactive).

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@leog leog added the performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive label Jul 18, 2023
@leog leog requested a review from a team July 18, 2023 20:51
@leog leog self-assigned this Jul 18, 2023
@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Jul 18, 2023

🤖 Meticulous spotted visual differences in 94 of 214 screens tested: view and approve differences detected.

Last updated for commit 79b026d. This comment will update as new commits are pushed.

@leog leog added this to the v3.2 milestone Jul 18, 2023
@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview Jul 18, 2023 8:53pm
cal ✅ Ready (Inspect) Visit Preview Jul 18, 2023 8:53pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 8:53pm
ui ✅ Ready (Inspect) Visit Preview Jul 18, 2023 8:53pm

@github-actions github-actions Bot added event-types area: event types, event-types High priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Jul 18, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jul 18, 2023

Current Playwright Test Results Summary

✅ 94 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/18/2023 09:02:17pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 79b026d

Started: 07/18/2023 09:00:07pm UTC

⚠️ Flakes

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1Initial Attempt
5.88% (12) 12 / 204 runs
failed over last 7 days
42.16% (86) 86 / 204 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
1.23% (2) 2 / 163 runs
failed over last 7 days
98.16% (160) 160 / 163 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes needed? or do we have a prettier mis match

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier yeah

Copy link
Copy Markdown
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good - Thanks

@PeerRich PeerRich merged commit 09068b3 into main Jul 18, 2023
@PeerRich PeerRich deleted the perf/event-type-page branch July 18, 2023 21:18
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working core area: core, team members only event-types area: event types, event-types High priority Created by Linear-GitHub Sync performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

Loading time after clicking edit

4 participants