Conversation
|
🤖 Meticulous spotted visual differences in 94 of 214 screens tested: view and approve differences detected. Last updated for commit 79b026d. This comment will update as new commits are pushed. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for following the naming conventions! 🙏 |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 94 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/18/2023 09:02:17pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 79b026d Started: 07/18/2023 09:00:07pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1 • Initial Attempt |
5.88% (12)12 / 204 runsfailed over last 7 days |
42.16% (86)86 / 204 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
1.23% (2)2 / 163 runsfailed over last 7 days |
98.16% (160)160 / 163 runsflaked over last 7 days |
There was a problem hiding this comment.
These changes needed? or do we have a prettier mis match
sean-brydon
left a comment
There was a problem hiding this comment.
Changes look good - Thanks
What does this PR do?
Follows some suggestion to reduce re-renders on a couple of high profile components needed for event-type config page to improve performance. One is related to avoid changing children to re-render by componentizing to behave as an atomic block and the other is to avoid relying on objects when passing down properties.
Fixes #9944
Type of change
How should this be tested?
Open an Event Type config page, it should have to process less re-renders, reducing the TTI (time-to-interactive).
Mandatory Tasks