Skip to content

fix: Booking Form - Prefill username and email from session [New Booker Regression]#10240

Merged
keithwillcode merged 1 commit intomainfrom
fix-loggedin-user-prefill
Jul 19, 2023
Merged

fix: Booking Form - Prefill username and email from session [New Booker Regression]#10240
keithwillcode merged 1 commit intomainfrom
fix-loggedin-user-prefill

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Jul 19, 2023

What does this PR do?

Fixes #10227

After Fix Demo

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Logged in Scenario
  • Non Logged in Scenario
    • Visit app.cal.local:3000/pro/30min
    • See that the prefill query params are prefilled in the form

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
api ✅ Ready (Inspect) Visit Preview Jul 19, 2023 3:07am
cal ✅ Ready (Inspect) Visit Preview Jul 19, 2023 3:07am
cal-demo ✅ Ready (Inspect) Visit Preview Jul 19, 2023 3:07am
ui ✅ Ready (Inspect) Visit Preview Jul 19, 2023 3:07am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 19, 2023

Thank you for following the naming conventions! 🙏

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Jul 19, 2023

🤖 Meticulous spotted visual differences in 27 of 112 screens tested: view and approve differences detected.

Last updated for commit 5b7cd01. This comment will update as new commits are pushed.

@zomars zomars added the core area: core, team members only label Jul 19, 2023
@hariombalhara hariombalhara requested a review from a team July 19, 2023 03:07
@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@hariombalhara hariombalhara self-assigned this Jul 19, 2023
@hariombalhara hariombalhara added 📉 regressing This used to work. Now it doesn't anymore. High priority Created by Linear-GitHub Sync labels Jul 19, 2023
@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jul 19, 2023

Current Playwright Test Results Summary

✅ 71 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/19/2023 03:16:05am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 5b7cd01

Started: 07/19/2023 03:14:31am UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1Initial Attempt
17.54% (50) 50 / 285 runs
failed over last 7 days
25.26% (72) 72 / 285 runs
flaked over last 7 days

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
pro user can reschedule a booking
Retry 1Initial Attempt
0.34% (1) 1 / 292 run
failed over last 7 days
2.74% (8) 8 / 292 runs
flaked over last 7 days

View Detailed Build Results


@hariombalhara hariombalhara added this to the v3.2 milestone Jul 19, 2023
@keithwillcode keithwillcode merged commit 902bb71 into main Jul 19, 2023
@keithwillcode keithwillcode deleted the fix-loggedin-user-prefill branch July 19, 2023 04:44
@PeerRich
Copy link
Copy Markdown
Member

awesome stuff!

Copy link
Copy Markdown
Contributor

@shivamklr shivamklr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only High priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore.

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

Prefill Username + Email in booking page when logged in.

5 participants