Skip to content

fix: More Brand color for calendar view#10252

Merged
PeerRich merged 1 commit intocalcom:mainfrom
anikdhabal:issue#10250
Jul 19, 2023
Merged

fix: More Brand color for calendar view#10252
PeerRich merged 1 commit intocalcom:mainfrom
anikdhabal:issue#10250

Conversation

@anikdhabal
Copy link
Copy Markdown
Contributor

@anikdhabal anikdhabal commented Jul 19, 2023 •
edited
Loading

What does this PR do?

Fixes #10250

Screenshot 2023-07-19 192450

Screenshot 2023-07-19 193537

  • Bug fix (non-breaking change which fixes an issue)

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2023 10:21pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2023 10:21pm

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 19, 2023

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✨ feature New feature or request labels Jul 19, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 19, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 19, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Forty-eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 273.81 KB 427.3 KB 122.09% (🟢 -0.19%)
/apps/[slug] 291.88 KB 445.36 KB 127.25% (🟢 -0.19%)
/apps/[slug]/[...pages] 424.67 KB 578.16 KB 165.19% (🟢 -0.29%)
/apps/categories 252.98 KB 406.47 KB 116.13% (🟢 -0.18%)
/apps/categories/[category] 257.04 KB 410.52 KB 117.29% (🟢 -0.18%)
/apps/installed/[category] 273.24 KB 426.73 KB 121.92% (🟢 -0.19%)
/availability 258.51 KB 412 KB 117.72% (🟢 -0.19%)
/availability/troubleshoot 253.72 KB 407.21 KB 116.34% (🟢 -0.18%)
/event-types/[type] 281.79 KB 435.28 KB 124.37% (🟢 -0.19%)
/getting-started/[[...step]] 408.33 KB 561.82 KB 160.52% (🟢 -0.23%)
/insights 464.77 KB 618.25 KB 176.64% (🟢 -0.19%)
/more 252.61 KB 406.1 KB 116.03% (🟢 -0.19%)
/settings/admin 258.36 KB 411.84 KB 117.67% (🟢 -0.19%)
/settings/admin/apps 269.57 KB 423.05 KB 120.87% (🟢 -0.19%)
/settings/admin/apps/[category] 269.53 KB 423.01 KB 120.86% (🟢 -0.19%)
/settings/admin/flags 261.85 KB 415.34 KB 118.67% (🟢 -0.19%)
/settings/admin/impersonation 258.63 KB 412.12 KB 117.75% (🟢 -0.19%)
/settings/admin/organizations 259.42 KB 412.91 KB 117.97% (🟢 -0.18%)
/settings/admin/users 260.4 KB 413.89 KB 118.25% (🟢 -0.18%)
/settings/admin/users/[id]/edit 339.95 KB 493.44 KB 140.98% (🟢 -0.19%)
/settings/admin/users/add 339.63 KB 493.12 KB 140.89% (🟢 -0.19%)
/settings/billing 258.52 KB 412.01 KB 117.72% (🟢 -0.19%)
/settings/developer/api-keys 263.04 KB 416.53 KB 119.01% (🟢 -0.19%)
/settings/developer/webhooks 262.52 KB 416.01 KB 118.86% (🟢 -0.19%)
/settings/developer/webhooks/[id] 263.89 KB 417.38 KB 119.25% (🟢 -0.19%)
/settings/developer/webhooks/new 263.76 KB 417.25 KB 119.21% (🟢 -0.19%)
/settings/my-account/appearance 270.07 KB 423.56 KB 121.02% (🟢 -0.19%)
/settings/my-account/calendars 264.87 KB 418.36 KB 119.53% (🟢 -0.19%)
/settings/my-account/conferencing 264.35 KB 417.84 KB 119.38% (🟢 -0.19%)
/settings/my-account/general 344.02 KB 497.51 KB 142.14% (🟢 -0.18%)
/settings/my-account/profile 386.87 KB 540.36 KB 154.39% (🟢 -0.19%)
/settings/organizations/appearance 265.22 KB 418.71 KB 119.63% (🟢 -0.19%)
/settings/organizations/billing 258.36 KB 411.85 KB 117.67% (🟢 -0.19%)
/settings/organizations/general 338.99 KB 492.47 KB 140.71% (🟢 -0.19%)
/settings/organizations/profile 380.92 KB 534.41 KB 152.69% (🟢 -0.19%)
/settings/security/impersonation 261.01 KB 414.5 KB 118.43% (🟢 -0.19%)
/settings/security/password 264.19 KB 417.68 KB 119.34% (🟢 -0.19%)
/settings/security/sso 267.79 KB 421.28 KB 120.37% (🟢 -0.19%)
/settings/security/two-factor-auth 263.6 KB 417.08 KB 119.17% (🟢 -0.19%)
/settings/teams 258.12 KB 411.61 KB 117.60% (🟢 -0.19%)
/settings/teams/[id]/appearance 267.82 KB 421.31 KB 120.37% (🟢 -0.19%)
/settings/teams/[id]/billing 258.37 KB 411.85 KB 117.67% (🟢 -0.19%)
/settings/teams/[id]/profile 449.35 KB 602.84 KB 172.24% (🟢 -0.19%)
/settings/teams/[id]/sso 267.89 KB 421.38 KB 120.39% (🟢 -0.18%)
/teams 252.76 KB 406.25 KB 116.07% (🟢 -0.18%)
/video/[uid] 248.2 KB 401.69 KB 114.77% (🟡 +0.23%)
/workflows 279.06 KB 432.55 KB 123.59% (🟢 -0.19%)
/workflows/[workflow] 392.3 KB 545.78 KB 155.94% (🟢 -0.18%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@PeerRich PeerRich requested a review from a team July 19, 2023 22:15
PeerRich
PeerRich approved these changes Jul 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm! lets also do the column view next in a new PR!

@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Jul 19, 2023

/tip 20

@PeerRich PeerRich merged commit 47f65bb into calcom:main Jul 19, 2023
@algora-pbc
Copy link
Copy Markdown

algora-pbc Bot commented Jul 19, 2023

@anikdhabal: You just got a $20 tip! 👉 Complete your Algora onboarding to collect your payment.

@anikdhabal
Copy link
Copy Markdown
Contributor Author

anikdhabal commented Jul 20, 2023

works like a charm! lets also do the column view next in a new PR!

For sure! Thank you.

@algora-pbc
Copy link
Copy Markdown

algora-pbc Bot commented Jul 20, 2023

🎉🎈 @anikdhabal has been awarded $20! 🎈🎊

@algora-pbc algora-pbc Bot added the 💰 Rewarded Rewarded bounties on Algora.io label Jul 20, 2023
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
@anikdhabal @fritterhoff
fix: More Brand color for calendar view (calcom#10252)
ed11ec9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeerRich PeerRich PeerRich approved these changes

Assignees

No one assigned

Labels

✨ feature New feature or request Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work 💰 Rewarded Rewarded bounties on Algora.io ui area: UI, frontend, button, form, input

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CAL-2205] ui: more brand color for calendar view

2 participants

@anikdhabal @PeerRich