Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 |
|
|
||
| await expect(page.locator(`[data-testid=two-factor-switch][data-state="checked"]`)).toBeVisible(); | ||
| await page.waitForSelector(`[data-testid=two-factor-switch]`); | ||
| await expect(page.locator(`[data-testid=two-factor-switch]`)).toBeTruthy(); |
There was a problem hiding this comment.
Rather than just waiting for the switch to appear. Also expect that it is set to true
There was a problem hiding this comment.
I don't think this checks if it is checked- rather whether the locator for the switch is truthy, so whenever it's present. There's an isChecked param in page. though.
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 95 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/20/2023 07:40:28pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: f03d3b6 Started: 07/20/2023 07:38:25pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
1.09% (2)2 / 184 runsfailed over last 7 days |
98.37% (181)181 / 184 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 2 • Retry 1 • Initial Attempt |
7.65% (15)15 / 196 runsfailed over last 7 days |
40.82% (80)80 / 196 runsflaked over last 7 days |
3 participants
What does this PR do?
This PR fixes the "enable 2FA test" by waiting for the enable 2FA dialog box to disappear and wait to see if the enable 2FA switch is set to
trueFixes # (issue)
Requirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks
Checklist