fix: Fix UI issues on embed popup footer#10286
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 96 Passing - ❌ 1 Failing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/24/2023 06:15:48am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 74d994e Started: 07/24/2023 06:13:20am UTC ❌ Failures📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 FailureTest Case Results
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
1.85% (3)3 / 162 runsfailed over last 7 days |
96.91% (157)157 / 162 runsflaked over last 7 days |
PeerRich
added
Medium priority
gitstart-calcom
force-pushed
the
fix-embed-footer
branch
from
dc2fefe to
1a1f1a1
Compare
|
🤖 Meticulous spotted visual differences in 38 of 123 screens tested: view and approve differences detected. Last updated for commit 74d994e. This comment will update as new commits are pushed. |
gitstart-calcom
force-pushed
the
fix-embed-footer
branch
from
1a1f1a1 to
74d994e
Compare
hariombalhara
approved these changes
Jul 24, 2023
fritterhoff
pushed a commit
to hm-edu/cal.com
that referenced
this pull request
Jul 25, 2023
Co-authored-by: gitstart-calcom <gitstart@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIGMA
DEMO
LOOM: https://www.loom.com/share/5ed7b0b8449140f0845e725ea99201b1