fix: name value can be undefined for existing name type fields#10298
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
name type fieldsundefined for existing name type fields
undefined for existing name type fieldsundefined for existing name type fields
|
🤖 Meticulous spotted visual differences in 82 of 207 screens tested: view and approve differences detected. Last updated for commit ed8a4ae. This comment will update as new commits are pushed. |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
emrysal
pushed a commit
that referenced
this pull request
Jul 21, 2023
fritterhoff
pushed a commit
to hm-edu/cal.com
that referenced
this pull request
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes booking page crash when a user has a legacy
nametype of field which was simply a text field. Now,namefield is much more than that.Type of change
How should this be tested?
Mandatory Tasks
Checklist
Couple of findings