fix: nameless in sidebar for orgs

[hariombalhara]

What does this PR do?

• Revert stale Infinite from getBranding query so that it is updated when org updates. It is easier then manually retching when some data changes. This actually fixes the bug where nameless is shown when a new org is created.
• Replace useOrgBrandingValues with useOrgBranding which gets the value from Provider. This would avoid unnecessary refetch of getBranding data which doesn't change frequently.

Fixes #10310

Type of change

• Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Mandatory Tasks

• Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

• I haven't added tests that prove my fix is effective or that my feature works

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 24, 2023 10:26am
cal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 24, 2023 10:26am
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 24, 2023 10:26am
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 24, 2023 10:26am

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)			Jul 24, 2023 10:26am
qa	⬜️ Ignored (Inspect)			Jul 24, 2023 10:26am

[github-actions]

Thank you for following the naming conventions! 🙏

[hariombalhara]

The value can itself be null if the user isn't an org member. So, make a wrapper object that has orgBrand and that wrapper objet can be checked if it's nullish or not.

[github-actions]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[alwaysmeticulous]

🤖 Meticulous spotted visual differences in 36 of 149 screens tested: view and approve differences detected.

_{Last updated for commit a5f0731. This comment will update as new commits are pushed.}

[deploysentinel]

Current Playwright Test Results Summary

✅ 93 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/24/2023 10:25:26am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: a5f0731

Started: 07/24/2023 10:23:16am UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 2 • Retry 1 • Initial Attempt	1.80% (3) 3 / 167 runs failed over last 7 days	97.01% (162) 162 / 167 runs flaked over last 7 days

---

View Detailed Build Results

---

[sean-brydon]

Tested -> Works great!

Nice work on fetching from provider instread of trpc each time we need it. We could likely do this across the app for a few things!