Skip to content

fix: Update ImageUploader.tsx#10319

Merged
PeerRich merged 4 commits into
calcom:mainfrom
fancymithun:fancymithun-patch-1-1-1
Jul 24, 2023
Merged

fix: Update ImageUploader.tsx#10319
PeerRich merged 4 commits into
calcom:mainfrom
fancymithun:fancymithun-patch-1-1-1

Conversation

@fancymithun
Copy link
Copy Markdown
Contributor

@fancymithun fancymithun commented Jul 23, 2023 •
edited
Loading

Fixes #10309

Updated Dialog Footer of Image Upload Component

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 10:06am

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 23, 2023

@fancymithun is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added organizations area: organizations, orgs ui area: UI, frontend, button, form, input ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup labels Jul 23, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 23, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏

@fancymithun fancymithun changed the title Update ImageUploader.tsx fix : Update ImageUploader.tsx Jul 23, 2023
@fancymithun fancymithun changed the title fix : Update ImageUploader.tsx fix: Update ImageUploader.tsx Jul 23, 2023
@Udit-takkar Udit-takkar self-requested a review July 23, 2023 09:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 23, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

fix: formatting
57cf556 
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@PeerRich PeerRich enabled auto-merge (squash) July 24, 2023 10:02
@PeerRich PeerRich added 🐛 bug Something isn't working 📉 regressing This used to work. Now it doesn't anymore. Medium priority Created by Linear-GitHub Sync labels Jul 24, 2023
@PeerRich PeerRich merged commit 80a1458 into calcom:main Jul 24, 2023
fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023
@fancymithun @PeerRich @fritterhoff
fix: Update ImageUploader.tsx (calcom#10319)
ccf172f 
Co-authored-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
@Udit-takkar Udit-takkar mentioned this pull request Jul 26, 2023
Closed
@BhuvaneshPatil BhuvaneshPatil mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeerRich PeerRich PeerRich approved these changes

@Udit-takkar Udit-takkar Udit-takkar approved these changes

Assignees

No one assigned

Labels

🐛 bug Something isn't working Medium priority Created by Linear-GitHub Sync 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup organizations area: organizations, orgs ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work 📉 regressing This used to work. Now it doesn't anymore. ui area: UI, frontend, button, form, input

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CAL-2217] Org onboarding: Upload avatar modal UI issues

3 participants

@fancymithun @PeerRich @Udit-takkar