test: Add Embed close modal test#10323
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
|
🤖 Meticulous spotted visual differences in 33 of 92 screens tested: view and approve differences detected. Last updated for commit 4a55fdc. This comment will update as new commits are pushed. |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 87 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/23/2023 12:44:23pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 4a55fdc Started: 07/23/2023 12:42:26pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
12.60% (33)33 / 262 runsfailed over last 7 days |
35.11% (92)92 / 262 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user can add multiple organizer address
Retry 1 • Initial Attempt |
1.43% (4)4 / 280 runsfailed over last 7 days |
10% (28)28 / 280 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt |
1.95% (3)3 / 154 runsfailed over last 7 days |
96.75% (149)149 / 154 runsflaked over last 7 days |
hariombalhara
commented
Jul 23, 2023
emrysal
approved these changes
Jul 23, 2023
Contributor
emrysal
left a comment
emrysal
left a comment
There was a problem hiding this comment.
Nice cleanup of existing tests too
fritterhoff
pushed a commit
to hm-edu/cal.com
that referenced
this pull request
Jul 25, 2023
* Add close modal test * Update packages/embeds/embed-core/playwright/lib/testUtils.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a test to verify that clicking close, actually hides the backdrop and iframe
Fixes #10322
Type of change
Mandatory Tasks