Skip to content

feat: Don't run middleware on _next, .*avatar.png & favicon.ico#10344

Merged
zomars merged 1 commit into
mainfrom
feat/reduce-middleware-invocations
Jul 24, 2023
Merged

feat: Don't run middleware on _next, .*avatar.png & favicon.ico#10344
zomars merged 1 commit into
mainfrom
feat/reduce-middleware-invocations

Conversation

@emrysal
Copy link
Copy Markdown
Contributor

@emrysal emrysal commented Jul 24, 2023

What does this PR do?

Reduce middleware activity for _next/* avatar.png & favicon.icon

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 4:23pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 4:23pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 4:23pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 4:23pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Jul 24, 2023 4:23pm

@emrysal emrysal requested review from keithwillcode and zomars July 24, 2023 16:18
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Jul 24, 2023

🤖 Meticulous spotted visual differences in 64 of 206 screens tested: view and approve differences detected.

Last updated for commit afe9999. This comment will update as new commits are pushed.

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Jul 24, 2023

Current Playwright Test Results Summary

✅ 97 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/24/2023 04:27:45pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: afe9999

Started: 07/24/2023 04:26:11pm UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
1.66% (3) 3 / 181 runs
failed over last 7 days
97.24% (176) 176 / 181 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
BOOKING_REJECTED can book an event that requires confirmation and then that booking can be rejected by organizer
Retry 1Initial Attempt
0.31% (1) 1 / 320 run
failed over last 7 days
4.69% (15) 15 / 320 runs
flaked over last 7 days

View Detailed Build Results


@zomars zomars merged commit 0138fdd into main Jul 24, 2023
@zomars zomars deleted the feat/reduce-middleware-invocations branch July 24, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants