fix: Onboarding wizard improvements [CAL-2229]#10346
Merged
Merged
Conversation
CAL-2229 Organizations: Members should only pick a username in the org, not a regular one
8d127ee7-e050-4404-8652-12783fd8eb5c When I follow an invite as a member, I am asked to input a username for the org (expected) but then also a regular cal.com username in the next step. I should not have to pick a second username. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
|
🤖 Meticulous spotted visual differences in 41 of 236 screens tested: view and approve differences detected. Last updated for commit 49907f7. This comment will update as new commits are pushed. |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 96 Passing - ❌ 1 Failing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/24/2023 08:19:40pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 49907f7 Started: 07/24/2023 08:17:38pm UTC ❌ Failures📄 packages/embeds/embed-core/playwright/tests/embed-pages.e2e.ts • 1 FailureTest Case Results
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
10.10% (31)31 / 307 runsfailed over last 7 days |
36.16% (111)111 / 307 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
1.65% (3)3 / 182 runsfailed over last 7 days |
97.25% (177)177 / 182 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
0% (0)0 / 182 runsfailed over last 7 days |
6.04% (11)11 / 182 runsflaked over last 7 days |
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0% (0)0 / 182 runsfailed over last 7 days |
4.95% (9)9 / 182 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user can add multiple organizer address
Retry 1 • Initial Attempt |
1.23% (4)4 / 326 runsfailed over last 7 days |
10.43% (34)34 / 326 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1 • Initial Attempt |
9.95% (19)19 / 191 runsfailed over last 7 days |
37.17% (71)71 / 191 runsflaked over last 7 days |
📄 apps/web/playwright/managed-event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Managed Event Types tests Can create managed event type
Retry 1 • Initial Attempt |
1.23% (4)4 / 326 runsfailed over last 7 days |
10.74% (35)35 / 326 runsflaked over last 7 days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a user created their user through an org invitation, they picked up a username that will then be presented again to be picked in the onboarding wizard. That part was hidden when coming from signup.
Also, a verification email was being sent to the invited user even after creating an account accepting the invitation clicking on the button of the invitation email, which was redundant, so the verification email was also refactored to no be sent for org signup.
Type of change
How should this be tested?
Invite a user to an organization and click the button of the email to create an account. Username in onboarding wizard should not be shown, and verification email should not be sent.
Mandatory Tasks