fix: Conferencing Label When Installing Apps by joeauyeung · Pull Request #10351 · calcom/cal.diy

joeauyeung · 2023-07-24T22:59:46Z

What does this PR do?

Disables install conferencing apps on teams & orgs until the PR is ready.

Fixes # (issue)

Type of change

Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Create a team or org
Install a video app
- The only option should be to install the app to the user

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

I haven't added tests that prove my fix is effective or that my feature works
I haven't checked if new and existing unit tests pass locally with my changes

vercel · 2023-07-24T22:59:52Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2023 0:46am
cal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2023 0:46am
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2023 0:46am
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2023 0:46am

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)			Jul 25, 2023 0:46am
qa	⬜️ Ignored (Inspect)			Jul 25, 2023 0:46am

github-actions · 2023-07-24T22:59:59Z

Thank you for following the naming conventions! 🙏

alwaysmeticulous · 2023-07-24T23:02:55Z

🤖 Meticulous spotted visual differences in 35 of 230 screens tested: view and approve differences detected.

_{Last updated for commit 4ec5bb5. This comment will update as new commits are pushed.}

github-actions · 2023-07-24T23:07:52Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-07-24T23:08:33Z

Current Playwright Test Results Summary

✅ 96 Passing - ❌ 1 Failing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/25/2023 12:47:13am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 4ec5bb5

Started: 07/25/2023 12:45:42am UTC

❌ Failures

📄 packages/embeds/embed-core/playwright/tests/embed-pages.e2e.ts • 1 Failure

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Embed Pages Event Type Page: should not have margin top on embed page Retry 2 • Retry 1 • Initial Attempt Error: expect(received).toBe(expected) // Object.is equality... `expect(received).toBe(expected) // Object.is equality Expected: 0 Received: null`	5.81% (9) 9 / 155 runs failed over last 7 days	0.65% (1) 1 / 155 run flaked over last 7 days

⚠️ Flakes

📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download Retry 1 • Initial Attempt	10.69% (17) 17 / 159 runs failed over last 7 days	35.22% (56) 56 / 159 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	1.29% (2) 2 / 155 runs failed over last 7 days	98.06% (152) 152 / 155 runs flaked over last 7 days

View Detailed Build Results

zomars

Can we check why there are type errors in the PR? 🙏🏽

Co-authored-by: Omar López <zomars@me.com>

joeauyeung · 2023-07-25T00:39:11Z

+  const enabledOnTeams = !app.categories.some(
+    (category) => category === "calendar" || category === "conferencing"
+  );


@zomars, I need to add a check for concurrent meetings when enabling team conferencing apps. This is just a part of the stack of PRs that would be nice to have in prod.

hariombalhara · 2023-07-25T06:27:27Z

+    (category) => category === "calendar" || category === "conferencing"
+  );
+
+  const appInstalled = enabledOnTeams && userAdminTeams ? userAdminTeams.length === appAdded : appAdded > 0;


nit:
Creating this variable would make things obvious isAppInstalledForAllTargets = userAdminTeams.length === appAdded

Fixed

Co-authored-by: Omar López <zomars@me.com>

Fix app category from video to conferencing

df0b6c3

zomars added the core area: core, team members only label Jul 24, 2023

vercel Bot had a problem deploying to Preview – api July 24, 2023 23:00 Failure

vercel Bot deployed to Preview – ui July 24, 2023 23:00 View deployment

vercel Bot deployed to Preview – dev July 24, 2023 23:02 View deployment

vercel Bot deployed to Preview – cal-demo July 24, 2023 23:03 View deployment

joeauyeung requested a review from a team July 24, 2023 23:04

zomars previously requested changes Jul 24, 2023

View reviewed changes

Comment thread apps/web/components/apps/App.tsx Outdated

joeauyeung and others added 2 commits July 24, 2023 20:35

Refactor to use includes

d101eea

Co-authored-by: Omar López <zomars@me.com>

Remove concurrent meeting

4ec5bb5

joeauyeung commented Jul 25, 2023

View reviewed changes

joeauyeung requested a review from zomars July 25, 2023 00:39

vercel Bot deployed to Preview – ui July 25, 2023 00:41 View deployment

vercel Bot deployed to Preview – dev July 25, 2023 00:45 View deployment

vercel Bot deployed to Preview – api July 25, 2023 00:46 View deployment

vercel Bot deployed to Preview – cal-demo July 25, 2023 00:46 View deployment

joeauyeung mentioned this pull request Jul 25, 2023

perf: Refactor getEnabledApps to filter on credentials passed #10353

Merged

2 tasks

joeauyeung self-assigned this Jul 25, 2023

joeauyeung added Medium priority Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync and removed Medium priority Created by Linear-GitHub Sync labels Jul 25, 2023

hariombalhara reviewed Jul 25, 2023

View reviewed changes

hariombalhara approved these changes Jul 25, 2023

View reviewed changes

hariombalhara merged commit 0e62c41 into main Jul 25, 2023

hariombalhara deleted the fix/multiinstall-conferencing-apps branch July 25, 2023 06:33

fritterhoff pushed a commit to hm-edu/cal.com that referenced this pull request Jul 25, 2023

fix: Conferencing Label When Installing Apps (calcom#10351)

527dc23

Co-authored-by: Omar López <zomars@me.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Conferencing Label When Installing Apps#10351

fix: Conferencing Label When Installing Apps#10351
hariombalhara merged 3 commits into
mainfrom
fix/multiinstall-conferencing-apps

joeauyeung commented Jul 24, 2023

Uh oh!

vercel Bot commented Jul 24, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 24, 2023 •

edited

Loading

Uh oh!

alwaysmeticulous Bot commented Jul 24, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 24, 2023 •

edited

Loading

Uh oh!

deploysentinel Bot commented Jul 24, 2023 •

edited

Loading

Test Case Results

Test Case Results

Test Case Results

Uh oh!

zomars left a comment

Uh oh!

Uh oh!

joeauyeung Jul 25, 2023

Uh oh!

hariombalhara Jul 25, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

joeauyeung commented Jul 24, 2023

What does this PR do?

Type of change

How should this be tested?

Mandatory Tasks

Checklist

Uh oh!

vercel Bot commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alwaysmeticulous Bot commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

deploysentinel Bot commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

❌ Failures

Test Case Results

⚠️ Flakes

Test Case Results

Test Case Results

Uh oh!

zomars left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joeauyeung Jul 25, 2023

Choose a reason for hiding this comment

Uh oh!

hariombalhara Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel Bot commented Jul 24, 2023 •

edited

Loading

github-actions Bot commented Jul 24, 2023 •

edited

Loading

alwaysmeticulous Bot commented Jul 24, 2023 •

edited

Loading

github-actions Bot commented Jul 24, 2023 •

edited

Loading

deploysentinel Bot commented Jul 24, 2023 •

edited

Loading

hariombalhara Jul 25, 2023 •

edited

Loading