chore: make Embed and AppStore Tests required#10358
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 |
hariombalhara
added
High priority
|
|
||
| e2e-embed-react: | ||
| name: E2E React embeds tests | ||
| if: ${{ needs.changes.outputs.embed-react == 'true' }} |
There was a problem hiding this comment.
Now there is no condition to run these checks.
|
|
||
| required: | ||
| needs: [lint, type-check, test, build, e2e] | ||
| needs: [lint, type-check, test, build, e2e, e2e-embed, e2e-embed-react, e2e-app-store] |
There was a problem hiding this comment.
As there is no condition on these checks, we can require them here.
keithwillcode
left a comment
keithwillcode
left a comment
There was a problem hiding this comment.
@hariombalhara to avoid adding more minutes of wait time back to builds, let’s implement the matrix strategy like we have on the main e2e test suite.
keithwillcode
added
automated-tests
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 74 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/25/2023 10:03:28am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 2e951b2 Started: 07/25/2023 10:01:54am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
FORM_SUBMITTED can submit a form and get a submission event
Retry 1 • Initial Attempt |
0.70% (2)2 / 284 runsfailed over last 7 days |
4.58% (13)13 / 284 runsflaked over last 7 days |
|
🤖 Meticulous spotted visual differences in 34 of 231 screens tested: view and approve differences detected. Last updated for commit 2e951b2. This comment will update as new commits are pushed. |
|
@keithwillcode I have pushed the changes for matrix support. Yet to test them. But I noticed that the embed and AppStore tests don't take more time than core e2e tests. If I am right in that analysis, we don't need sharding.
|
|
@hariombalhara 13 minutes is what they used to take before I put the matrix in place. Now they only take 2-3 minutes. |
* Now, all tests are required * Add matrix support
* Now, all tests are required * Add matrix support
* Now, all tests are required * Add matrix support
3 participants
What does this PR do?
Make all tests required now.
A recent regression that could have been avoided if embed tests were required #10357
Side Note: Marked it High Priority as it's quick to merge and super important to have these tests block PR merge considering recent regression as well.