fix: responsive upload avatar#10392
Merged
Merged
Conversation
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
Bot
added
🎨 needs design
Contributor
|
Thank you for following the naming conventions! 🙏 |
|
🤖 Meticulous spotted visual differences in 65 of 304 screens tested: view and approve differences detected. Last updated for commit e18b120. This comment will update as new commits are pushed. |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 105 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/26/2023 11:51:59am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: e18b120 Started: 07/26/2023 11:47:34am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
1.52% (3)3 / 197 runsfailed over last 7 days |
97.97% (193)193 / 197 runsflaked over last 7 days |
Move title to the DialogContent title prop instead of the content.
emrysal
approved these changes
Jul 26, 2023
Contributor
emrysal
left a comment
emrysal
left a comment
There was a problem hiding this comment.
Good to go, thanks @Udit-takkar
joeauyeung
pushed a commit
that referenced
this pull request
Jul 26, 2023
* fix: responsive upload avatar Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * Update ImageUploader.tsx Move title to the DialogContent title prop instead of the content. --------- Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Alex van Andel <me@alexvanandel.com>
sean-brydon
pushed a commit
that referenced
this pull request
Jul 31, 2023
* fix: responsive upload avatar Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> * Update ImageUploader.tsx Move title to the DialogContent title prop instead of the content. --------- Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Co-authored-by: Alex van Andel <me@alexvanandel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10385
Requirement/Documentation
Type of change