chore: Skipping totp code for org dev#10403
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Thank you for following the naming conventions! 🙏 |
| WEBAPP_URL && | ||
| (new URL(WEBAPP_URL).hostname.endsWith("cal.com") || | ||
| new URL(WEBAPP_URL).hostname.endsWith("cal.dev") || | ||
| new URL(WEBAPP_URL).hostname.endsWith("cal.qa") || |
|
|
||
| export const CONSOLE_URL = | ||
| new URL(WEBAPP_URL).hostname.endsWith(".cal.dev") || | ||
| new URL(WEBAPP_URL).hostname.endsWith(".cal.qa") || |
| import { subdomainSuffix } from "@calcom/features/ee/organizations/lib/orgDomains"; | ||
| import { DEFAULT_SCHEDULE, getAvailabilityFromSchedule } from "@calcom/lib/availability"; | ||
| import { IS_PRODUCTION, IS_TEAM_BILLING_ENABLED, RESERVED_SUBDOMAINS } from "@calcom/lib/constants"; | ||
| import { IS_CALCOM, IS_TEAM_BILLING_ENABLED, RESERVED_SUBDOMAINS } from "@calcom/lib/constants"; |
There was a problem hiding this comment.
Relying on whether the environment is either Dev, QA, or PROD
| const availability = getAvailabilityFromSchedule(DEFAULT_SCHEDULE); | ||
|
|
||
| if (check === false) { | ||
| if (IS_CALCOM) await vercelCreateDomain(slug); |
There was a problem hiding this comment.
Moved up to fail before creating the team if vercel domain creation fails. And relying on whether the environment is either Dev, QA, or PROD
|
|
||
| if (!user || !email || !code) throw new TRPCError({ code: "BAD_REQUEST" }); | ||
|
|
||
| if (!IS_PRODUCTION) return true; |
There was a problem hiding this comment.
If not a PROD environment such as Local or Dev, accept any code.
|
🤖 Meticulous spotted visual differences in 54 of 251 screens tested: view and approve differences detected. Last updated for commit 8c045fd. This comment will update as new commits are pushed. |
Current Playwright Test Results Summary✅ 105 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 07/26/2023 04:07:04pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 8c045fd Started: 07/26/2023 04:05:32pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user can add multiple organizer address
Retry 1 • Initial Attempt |
1.32% (4)4 / 304 runsfailed over last 7 days |
14.47% (44)44 / 304 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Pending payment booking should not be confirmed by default
Retry 1 • Initial Attempt |
1.64% (5)5 / 304 runsfailed over last 7 days |
7.89% (24)24 / 304 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
1.40% (3)3 / 214 runsfailed over last 7 days |
98.13% (210)210 / 214 runsflaked over last 7 days |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
3 participants
What does this PR do?
When working with Org creation, TOTP code will accept any code for lower environments
Type of change
How should this be tested?
Create an org and when TOTP code is asked, enter any code. This only works for non-production environments, such as Local and Dev. QA and PROD will need an actual code.
Mandatory Tasks