Skip to content

fix: Calendar View #10514

Merged
PeerRich merged 9 commits intomainfrom
fix/calendarview-dates
Aug 9, 2023
Merged

fix: Calendar View #10514
PeerRich merged 9 commits intomainfrom
fix/calendarview-dates

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar commented Aug 1, 2023

What does this PR do?

Fixes #10428

TODO

  • Fix type errors

How to test this?

  1. Create availability in IST Timezone ( 9 -5 , mon-fri except wed)
  2. Set your system's time to New York
  3. go to booking page and select weekly view to verify if dates and slots are correct

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 5:12am
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 5:12am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 5:12am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 5:12am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 5:12am
qa ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 5:12am

@github-actions github-actions Bot added booking-page area: booking page, public booking page, booker 🐛 bug Something isn't working labels Aug 1, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 1, 2023

Thank you for following the naming conventions! 🙏

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Aug 1, 2023

🤖 Meticulous spotted visual differences in 28 of 213 screens tested: view and approve differences detected.

Last updated for commit a3bdb73. This comment will update as new commits are pushed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 1, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Aug 1, 2023

Current Playwright Test Results Summary

✅ 114 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/09/2023 05:14:59am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: a3bdb73

Started: 08/09/2023 05:13:23am UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1Initial Attempt
0.68% (2) 2 / 295 runs
failed over last 7 days
22.37% (66) 66 / 295 runs
flaked over last 7 days

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types tests Can create managed event type
Retry 1Initial Attempt
0.67% (2) 2 / 298 runs
failed over last 7 days
13.09% (39) 39 / 298 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
4.07% (12) 12 / 295 runs
failed over last 7 days
95.93% (283) 283 / 295 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The start day of the of the week is wrong, it always shows the day before the picked day:
Screenshot 2023-08-03 at 09 40 11

Comment thread packages/features/bookings/Booker/components/LargeCalendar.tsx Outdated
Comment thread packages/features/calendars/DatePicker.tsx Outdated
@CarinaWolli CarinaWolli requested a review from sean-brydon August 3, 2023 13:53
@Udit-takkar
Copy link
Copy Markdown
Contributor Author

@CarinaWolli so the only issue pending is that you see one previous day but are slots are in correct days column?

@CarinaWolli
Copy link
Copy Markdown
Member

@CarinaWolli so the only issue pending is that you see one previous day but are slots are in correct days column?

Yes slots are showing on the correct days now 👏🏻

@sean-brydon
Copy link
Copy Markdown
Member

CleanShot 2023-08-07 at 10 04 21@2x Issue is fixed - noticed another thing. When hovering / selecting a slot we get MY timezone and not the timezone of i have selected in the booker

@Udit-takkar
Copy link
Copy Markdown
Contributor Author

Udit-takkar commented Aug 8, 2023

Screenshot 2023-08-08 at 3 26 54 PM

Everything should be fixed now. Tested on multiple timezones

@Udit-takkar Udit-takkar requested a review from CarinaWolli August 8, 2023 19:27
@PeerRich PeerRich dismissed CarinaWolli’s stale review August 8, 2023 22:00

can you test again?

Udit Takkar and others added 9 commits August 9, 2023 10:25
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
Copy link
Copy Markdown
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2023-08-09 at 09 37 51@2x Seems to be working for me :) Great job! I know these TZ issues are a pain in the ass to work with!

@PeerRich PeerRich merged commit cf89598 into main Aug 9, 2023
@PeerRich PeerRich deleted the fix/calendarview-dates branch August 9, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

booking-page area: booking page, public booking page, booker 🐛 bug Something isn't working core area: core, team members only High priority Created by Linear-GitHub Sync

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

[CAL-2266] Slots are open on wrong day in weekly view

5 participants