fix: Only enforce min seats for orgs

[joeauyeung]

What does this PR do?

This PR fixes the logic to only change team subscription amounts for orgs and not normal teams

Fixes # (issue)

Requirement/Documentation

• If there is a requirement document, please, share it here.
• If there is ab UI/UX design document, please, share it here.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How should this be tested?

• Enable team billing
• Create a team and invite members
• Delete some members
• On Stripe the subscription count should be updated

Mandatory Tasks

• Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

• I haven't added tests that prove my fix is effective or that my feature works
• I haven't checked if new and existing unit tests pass locally with my changes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 3, 2023 6:24pm
cal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 3, 2023 6:24pm
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 3, 2023 6:24pm

3 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Aug 3, 2023 6:24pm
qa	⬜️ Ignored (Inspect)	Visit Preview		Aug 3, 2023 6:24pm
ui	⬜️ Ignored (Inspect)	Visit Preview		Aug 3, 2023 6:24pm

[github-actions]

Thank you for following the naming conventions! 🙏

[zomars]

We have done types failing

[alwaysmeticulous]

🤖 Meticulous spotted visual differences in 30 of 119 screens tested: view and approve differences detected.

_{Last updated for commit d533e86. This comment will update as new commits are pushed.}

[github-actions]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[deploysentinel]

Current Playwright Test Results Summary

✅ 115 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/03/2023 06:26:25pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: d533e86

Started: 08/03/2023 06:25:13pm UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	2.29% (7) 7 / 306 runs failed over last 7 days	95.75% (293) 293 / 306 runs flaked over last 7 days

---

View Detailed Build Results

---

[zomars]

Some Qs, I'm trying to understand the why of this.

• Where does the ORGANIZATION_MIN_SEATS number coming from?
• Will this affect non orgs teams sub update logic? How can we verify this?
• Is this related to the previous discussion where repeated members of different teams of the same org should not be charged?

[alannnc]

I think we can move this to it's own file? Unless it's being used multiple times on several files.

[joeauyeung]

Do you have a suggestion on where to move it? I figured the constants file would be an easy place to find this variable.

[alannnc]

Looks good, left a NIT comment.

[joeauyeung]

Some Qs, I'm trying to understand the why of this.

* Where does the ORGANIZATION_MIN_SEATS number coming from?

* Will this affect non orgs teams sub update logic? How can we verify this?

* Is this related to the previous discussion where repeated members of different teams of the same org should not be charged?

• The minimum number is coming from @shirazdole
• The problem was this logic before was affecting non-org teams. I tested this locally and checked the test Stripe dashboard, and the number of seats the customer was being charged is being updated with this fix. Regular teams will have normal members and not orgMembers
• That logic is handled somewhere else. This is only for removing team members

[zomars]

Thanks fro clarifying. LGTM