fix: showing default apps by Cal like Cal-Video in installed apps#10611
Merged
hariombalhara merged 3 commits intocalcom:mainfrom Aug 10, 2023
Merged
fix: showing default apps by Cal like Cal-Video in installed apps#10611hariombalhara merged 3 commits intocalcom:mainfrom
hariombalhara merged 3 commits intocalcom:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Someone is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
the
app-store
Contributor
|
Thank you for following the naming conventions! 🙏 |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
PeerRich
added
the
⚡ Quick Wins
joeauyeung
previously requested changes
Aug 8, 2023
Contributor
Author
|
please review @joeauyeung and thanks for the feedback |
hariombalhara
approved these changes
Aug 10, 2023
Member
hariombalhara
left a comment
hariombalhara
left a comment
There was a problem hiding this comment.
Let's improve the perf as a followup. Thanks @satya-nishanth 🙏
hariombalhara
dismissed
joeauyeung’s stale review
Performance to be improved in a followup. Bugfix first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the problem where default apps like cal-video are getting filtering out from installed apps
Fixes #10595
Earlier without this fix
After this fix
Type of change
How should this be tested?
go to /apps/installed/conferencing now you can see cal-video
Mandatory Tasks
Checklist