fix: add extra security layers for sending messages to attendees#10636
Merged
fix: add extra security layers for sending messages to attendees#10636
Conversation
added 16 commits
August 1, 2023 11:09
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
zomars
suggested changes
Aug 9, 2023
Contributor
zomars
left a comment
zomars
left a comment
There was a problem hiding this comment.
Codewise is looking pretty good. Can we check why the production build is failing?
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 New Pages AddedThe following pages were added to the bundle from the code in this PR:
Ninety-three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
|
No failed tests 🎉 |
Member
Author
|
@zomars fixed production build |
|
🤖 Meticulous spotted visual differences in 15 of 110 screens tested: view and approve differences detected. Last updated for commit 19876c8. This comment will update as new commits are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables sending SMS to attendees (reverts fix: temporarily disable sms/whatsapp to attendee workflow action #10485)
Only allow sending SMS to attendees when event type requires confirmation
You can still set an event type that does not require confirmation as active because this would be too complex to handle otherwise (workflow can have more actions, event type can be changed afterwards etc.). A warning message got added to make users aware.
Warning message when editing workflows:
Warning message when in the workflows tab of event types settings:
Only enable SMS/Whatsapp to attendee for users and teams that are verified
Dialog that opens when clicking on verify badge if user is part of team:
Dialog that opens when clicking on verify badge if user is not part of team:
Verify teams and users in admin settings:
Type of change
How should this be tested?
Mandatory Tasks