Skip to content

fix: Removing payment fee on stripe#10652

Merged
keithwillcode merged 7 commits into
mainfrom
fix-remove-stripe-app-fee-from-app-description
Aug 21, 2023
Merged

fix: Removing payment fee on stripe#10652
keithwillcode merged 7 commits into
mainfrom
fix-remove-stripe-app-fee-from-app-description

Conversation

@alannnc
Copy link
Copy Markdown
Contributor

@alannnc alannnc commented Aug 9, 2023

What does this PR do?

  • Removes from UI payment fees.
  • Didn't moved envs so we can reuse them in the future if required.

Fixes #10650

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@alannnc alannnc linked an issue Aug 9, 2023 that may be closed by this pull request
@alannnc alannnc requested a review from joeauyeung August 9, 2023 02:17
@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 2:31am
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 2:31am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 2:31am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 2:31am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Aug 18, 2023 2:31am
qa ⬜️ Ignored (Inspect) Visit Preview Aug 18, 2023 2:31am

@alannnc alannnc requested a review from a team August 9, 2023 02:17
@github-actions github-actions Bot added the ✨ feature New feature or request label Aug 9, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 9, 2023

Thank you for following the naming conventions! 🙏

@zomars zomars added the core area: core, team members only label Aug 9, 2023
</div>
</>
}>
}}>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to find a link on stripe connect fees, but they are specific for each country.

stripeAccount: this.credentials.stripe_user_id,
}) as unknown as Prisma.InputJsonValue,
fee: paymentFee,
fee: 0,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fee is required when creating payment.

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Aug 9, 2023

🤖 Meticulous spotted visual differences in 59 of 171 screens tested: view and approve differences detected.

Last updated for commit 1dc38e8. This comment will update as new commits are pushed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 9, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Aug 9, 2023

Current Playwright Test Results Summary

✅ 116 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/18/2023 02:31:58am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 1dc38e8

Started: 08/18/2023 02:30:56am UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
1.91% (5) 5 / 262 runs
failed over last 7 days
98.09% (257) 257 / 262 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED can submit a form and get a submission event
Retry 1Initial Attempt
2.65% (7) 7 / 264 runs
failed over last 7 days
25% (66) 66 / 264 runs
flaked over last 7 days

View Detailed Build Results


@PeerRich
Copy link
Copy Markdown
Member

PeerRich commented Aug 14, 2023

when are we planning to reintroduce it?

@keithwillcode keithwillcode added the Low priority Created by Linear-GitHub Sync label Aug 15, 2023
@alannnc
Copy link
Copy Markdown
Contributor Author

alannnc commented Aug 15, 2023

when are we planning to reintroduce it?

We already talked about something, at the end of the month calculate total % of booking paid and then charge the user with that fee.
Created RFC issue on linear: https://linear.app/calcom/issue/CAL-2356/rfc-calcom-booking-payment-fees
@PeerRich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only ✨ feature New feature or request Low priority Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-2323] Remove stripe app fee

5 participants