Skip to content

feat: send new booking uid on reschedule webhook#10654

Merged
CarinaWolli merged 9 commits intocalcom:mainfrom
wesleymatosdev:feat/send-new-booking-uid-on-reschedule-webhook
Sep 7, 2023
Merged

feat: send new booking uid on reschedule webhook#10654
CarinaWolli merged 9 commits intocalcom:mainfrom
wesleymatosdev:feat/send-new-booking-uid-on-reschedule-webhook

Conversation

@wesleymatosdev
Copy link
Copy Markdown
Contributor

@wesleymatosdev wesleymatosdev commented Aug 9, 2023

  • test: create test checking uid on BOOKING_RESCHEDULED webhook
  • refactor: move createUserWithSeatedEventAndAttendees to testUtils
  • refactor: add helper to create webhook receiver
  • test: add test case to booking with multiple seats being rescheduled
  • feat: return uid on any BOOKING_RESCHEDULED scenario

What does this PR do?

Fixes #10631

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

I added e2e tests, they should be executed on the pipeline without manual interaction

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 4:22pm

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 9, 2023

@ologbonowiwi is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added Medium priority Created by Linear-GitHub Sync webhooks area: webhooks, callback, webhook payload 🐛 bug Something isn't working labels Aug 9, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 9, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏

wesleymatosdev
wesleymatosdev commented Aug 9, 2023
View reviewed changes
Comment thread apps/web/playwright/webhook.e2e.ts
triggerEvent: "BOOKING_RESCHEDULED",
payload: {
// in the current implementation, it is the same as the first booking
uid: newBooking?.uid,
Copy link
Copy Markdown
Contributor Author

@wesleymatosdev wesleymatosdev Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was null before the changes on this PR.

wesleymatosdev
wesleymatosdev commented Aug 9, 2023
View reviewed changes
Comment thread packages/features/bookings/lib/handleNewBooking.ts Outdated
@wesleymatosdev wesleymatosdev mentioned this pull request Aug 9, 2023
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 9, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 24, 2023

This PR is being marked as stale due to inactivity.

@github-actions github-actions Bot added the Stale label Aug 24, 2023
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 28, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions Bot removed the Stale label Aug 29, 2023
CarinaWolli
CarinaWolli previously approved these changes Sep 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and tests are passing. Thank you for this fix 🙏

@CarinaWolli
Copy link
Copy Markdown
Member

CarinaWolli commented Sep 5, 2023

@ologbonowiwi Just saw that there are merge conflicts, could you take a look at that?

@CarinaWolli CarinaWolli enabled auto-merge (squash) September 7, 2023 15:27
CarinaWolli
CarinaWolli previously approved these changes Sep 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed merge conflicts

@CarinaWolli CarinaWolli merged commit db29cc1 into calcom:main Sep 7, 2023
ashwintelmore pushed a commit to ashwintelmore/cal.com that referenced this pull request Sep 19, 2023
@wesleymatosdev @ashwintelmore
feat: send new booking uid on reschedule webhook (calcom#10654)
015173b 
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarinaWolli CarinaWolli CarinaWolli approved these changes

Assignees

No one assigned

Labels

🐛 bug Something isn't working Medium priority Created by Linear-GitHub Sync webhooks area: webhooks, callback, webhook payload

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reschedule event webhook, payload not giving the new booking uid

4 participants

@wesleymatosdev @CLAassistant @CarinaWolli @PeerRich