fix: Orgs publishing with billing#10662
Merged
joeauyeung merged 2 commits intomainfrom Aug 9, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
joeauyeung
commented
Aug 9, 2023
Comment on lines
+43
to
+48
| if (!metadata.data?.requestedSlug) { | ||
| throw new HttpError({ | ||
| statusCode: 400, | ||
| message: "Can't publish team/org without `requestedSlug`", | ||
| }); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
All new team and org requests will contain requestedSlug
leog
changed the title
leog
added
organizations
|
🤖 Meticulous spotted visual differences in 50 of 89 screens tested: view and approve differences detected. Last updated for commit 9dcaeba. This comment will update as new commits are pushed. |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 114 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/09/2023 03:15:01pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 9dcaeba Started: 08/09/2023 03:12:38pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to disable 2FA
Retry 1 • Initial Attempt |
0.32% (1)1 / 310 runfailed over last 7 days |
4.52% (14)14 / 310 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
3.83% (12)12 / 313 runsfailed over last 7 days |
96.17% (301)301 / 313 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Paid booking should be able to be rescheduled
Retry 1 • Initial Attempt |
5.08% (16)16 / 315 runsfailed over last 7 days |
8.57% (27)27 / 315 runsflaked over last 7 days |
|
Stripe integration Can book a paid booking
Retry 1 • Initial Attempt |
4.43% (14)14 / 316 runsfailed over last 7 days |
7.28% (23)23 / 316 runsflaked over last 7 days |
📄 packages/app-store/typeform/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link should validate fields
Retry 1 • Initial Attempt |
0.95% (3)3 / 315 runsfailed over last 7 days |
9.21% (29)29 / 315 runsflaked over last 7 days |
leog
approved these changes
Aug 9, 2023
Contributor
leog
left a comment
leog
left a comment
There was a problem hiding this comment.
Code looks good. Couldn’t test it from preview as license key is missing somehow. Let’s proceed to merge it and test it fully in dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue with the orgs metadata being overwritten after checking with Stripe.
Fixes # (issue)
Requirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks
Checklist