Skip to content

fix: fetching team with parent#10677

Merged
leog merged 3 commits intomainfrom
fix/parent-org-subteam
Aug 9, 2023
Merged

fix: fetching team with parent#10677
leog merged 3 commits intomainfrom
fix/parent-org-subteam

Conversation

@leog
Copy link
Copy Markdown
Contributor

@leog leog commented Aug 9, 2023

What does this PR do?

Making sure we select the parent team on an org context (present orgSlug) and a different slug than the orgSlug.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  1. Create an org and have billing enabled
  2. Before paying the subscription, see the org is shown as unpublished
  3. After paying the subscription, the org public profile shows up instead of a 404 error

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@leog leog requested a review from a team August 9, 2023 19:34
@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 9:04pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 9:04pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 9:04pm
qa 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 9:04pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 9:04pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 9:04pm

@leog leog self-assigned this Aug 9, 2023
@leog leog added the organizations area: organizations, orgs label Aug 9, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 9, 2023

Thank you for following the naming conventions! 🙏

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Aug 9, 2023

🤖 Meticulous spotted visual differences in 61 of 169 screens tested: view and approve differences detected.

Last updated for commit 96b8194. This comment will update as new commits are pushed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 9, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Aug 9, 2023

Current Playwright Test Results Summary

✅ 114 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/09/2023 09:04:39pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 96b8194

Started: 08/09/2023 09:03:16pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
pro user can reschedule a booking
Retry 1Initial Attempt
2.99% (10) 10 / 334 runs
failed over last 7 days
6.59% (22) 22 / 334 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
4.27% (14) 14 / 328 runs
failed over last 7 days
95.73% (314) 314 / 328 runs
flaked over last 7 days

View Detailed Build Results


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only High priority Created by Linear-GitHub Sync organizations area: organizations, orgs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants