Skip to content

fix: Redirect URL After Upgrading#10680

Merged
leog merged 2 commits intomainfrom
fix/upgrade-redirect-url
Aug 10, 2023
Merged

fix: Redirect URL After Upgrading#10680
leog merged 2 commits intomainfrom
fix/upgrade-redirect-url

Conversation

@joeauyeung
Copy link
Copy Markdown
Contributor

@joeauyeung joeauyeung commented Aug 9, 2023

What does this PR do?

Fixes redirect URL after upgrading an organization or a team.

Fixes # (issue)

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 11:29pm
cal 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 11:29pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 11:29pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 11:29pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 11:29pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
qa ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2023 11:29pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 9, 2023

Thank you for following the naming conventions! 🙏

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Aug 9, 2023

🤖 Meticulous spotted visual differences in 49 of 287 screens tested: view and approve differences detected.

Last updated for commit 43fd6ec. This comment will update as new commits are pushed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 9, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Aug 9, 2023

Current Playwright Test Results Summary

✅ 114 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/09/2023 11:29:37pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 43fd6ec

Started: 08/09/2023 11:26:58pm UTC

⚠️ Flakes

📄   apps/web/playwright/availability.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Availablity tests Date Overrides
Retry 1Initial Attempt
0.29% (1) 1 / 341 run
failed over last 7 days
1.76% (6) 6 / 341 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
4.19% (14) 14 / 334 runs
failed over last 7 days
95.81% (320) 320 / 334 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Copy Markdown
Contributor

@leog leog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected, thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only organizations area: organizations, orgs

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants