Skip to content

fix: copy or view profile URL for org [CAL-2246]#10702

Merged
emrysal merged 1 commit intomainfrom
fix/copy-view-profile-url
Aug 10, 2023
Merged

fix: copy or view profile URL for org [CAL-2246]#10702
emrysal merged 1 commit intomainfrom
fix/copy-view-profile-url

Conversation

@leog
Copy link
Copy Markdown
Contributor

@leog leog commented Aug 10, 2023

What does this PR do?

Pushing little big fixes for Orgs, found that copy or view profile links in the sidebar were not being calculated correctly for an org, this fixes that issue.

Fixes #10368

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Create an org and when on app, try copying link or viewing org profile from sidebar menu. Remember locally the copying function is limited (will throw error) due to browser policies.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@leog leog added the organizations area: organizations, orgs label Aug 10, 2023
@leog leog added this to the v3.2 milestone Aug 10, 2023
@leog leog requested a review from sean-brydon August 10, 2023 15:37
@leog leog self-assigned this Aug 10, 2023
@linear
Copy link
Copy Markdown

linear Bot commented Aug 10, 2023

CAL-2246 Copy profile link doesn't work

When I click this:

Captura de pantalla 2023-07-25 a las 14.31.52.png

As you can see, it goes to the wrong link. Also this should include my profile picture in the URL

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 3:42pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 3:42pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 3:42pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 3:42pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Aug 10, 2023 3:42pm

@github-actions github-actions Bot added Medium priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Aug 10, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Aug 10, 2023

🤖 Meticulous spotted visual differences in 51 of 305 screens tested: view and approve differences detected.

Last updated for commit d20caf5. This comment will update as new commits are pushed.

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Aug 10, 2023

Current Playwright Test Results Summary

✅ 114 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/10/2023 03:48:20pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: d20caf5

Started: 08/10/2023 03:46:30pm UTC

⚠️ Flakes

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Pending payment booking should not be confirmed by default
Retry 1Initial Attempt
6.58% (21) 21 / 319 runs
failed over last 7 days
6.27% (20) 20 / 319 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED can submit a form and get a submission event
Retry 1Initial Attempt
2.27% (7) 7 / 309 runs
failed over last 7 days
26.54% (82) 82 / 309 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
5.40% (17) 17 / 315 runs
failed over last 7 days
94.60% (298) 298 / 315 runs
flaked over last 7 days

View Detailed Build Results


@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@emrysal emrysal merged commit 3c3564f into main Aug 10, 2023
@emrysal emrysal deleted the fix/copy-view-profile-url branch August 10, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working core area: core, team members only Medium priority Created by Linear-GitHub Sync organizations area: organizations, orgs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-2246] Copy profile link doesn't work

3 participants