fix: #10783 (UI updated on API Creation Form )#10786
Conversation
github-actions
Bot
added
Low priority
|
Thank you for following the naming conventions! 🙏 |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Someone is attempting to deploy a commit to the cal-staging Team on Vercel. A member of the Team first needs to authorize it. |
Udit-takkar
changed the title
Udit-takkar
left a comment
Udit-takkar
left a comment
There was a problem hiding this comment.
Even with bottom-0 i see everything fine. i can't reproduce the bug
Hey, I had also tested and If we remove bottom-0 it works on all devices and if we add bottom-0 it works on some devices and it won't work on some devices. Refer to this video: |
|
@hempun10 i am not able to push changes in the PR but this is what you would have to do. add bottom-0 again because it is requird in other dialogs which are scrollable. Just make this small change in Both DialogFooter in packages/features/ee/api-keys/components/ApiKeyDialogForm.tsx 
|
|
Hey @Udit-takkar I have updated the changes. Please feel free to review and back me with changes or suggestions. |
|
@hempun10 yeah make the same change in second dialogfooter in the same file |
@Udit-takkar Updated the changes required. |
3 participants
What does this PR do?
Fixes #10783
Requirement/Documentation
Before
After Updated UI
Type of change
How should this be tested?
Go to Developer Tab in settings and click on create a new API Key.
Mandatory Tasks