Skip to content

fix: GCal shared calendars write if enabled#10824

Merged
keithwillcode merged 1 commit into
mainfrom
fix/gcal-shared-calendars
Aug 18, 2023
Merged

fix: GCal shared calendars write if enabled#10824
keithwillcode merged 1 commit into
mainfrom
fix/gcal-shared-calendars

Conversation

@joeauyeung
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR allows users to select GCal calendars as the destination calendar if they are either the owner or have permission to write on it.

Fixes # (issue)

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Connect a Google account with a shared calendar with write access
  • When selecting a destination calendar, that shared calendar should now be an option
  • Create an event, the event should be created on the shared calendar

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 1:49am
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 1:49am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 1:49am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 1:49am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Aug 18, 2023 1:49am

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Aug 18, 2023

Current Playwright Test Results Summary

✅ 116 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/18/2023 01:49:37am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 651df04

Started: 08/18/2023 01:48:31am UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
1.92% (5) 5 / 260 runs
failed over last 7 days
98.08% (255) 255 / 260 runs
flaked over last 7 days

View Detailed Build Results


@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Aug 18, 2023

🤖 Meticulous spotted visual differences in 59 of 171 screens tested: view and approve differences detected.

Last updated for commit 651df04. This comment will update as new commits are pushed.

@keithwillcode keithwillcode merged commit d178962 into main Aug 18, 2023
@keithwillcode keithwillcode deleted the fix/gcal-shared-calendars branch August 18, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants