Skip to content

fix: missing border-subtle class#10838

Merged
sean-brydon merged 1 commit into
calcom:mainfrom
KoushikVanama:main
Aug 21, 2023
Merged

fix: missing border-subtle class#10838
sean-brydon merged 1 commit into
calcom:mainfrom
KoushikVanama:main

Conversation

@KoushikVanama
Copy link
Copy Markdown
Contributor

fix: missing border-subtle class
Fixes #10829

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 1:13pm

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 18, 2023

@KoushikVanama is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added Low priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✅ good first issue Good for newcomers labels Aug 18, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Fourteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 404.11 KB 558.27 KB 159.51% (🔴 +36.96%)
/[user]/[type]/embed 404.14 KB 558.3 KB 159.51% (🔴 +36.97%)
/apps/[slug]/[...pages] 618.5 KB 772.67 KB 220.76% (🔴 +27.00%)
/booking/[uid] 327.2 KB 481.36 KB 137.53% (🔴 +29.19%)
/bookings/[status] 344.61 KB 498.78 KB 142.51% (🟢 -0.41%)
/d/[link]/[slug] 404.12 KB 558.28 KB 159.51% (🔴 +36.97%)
/event-types 598.88 KB 753.05 KB 215.16% (🟡 +19.44%)
/event-types/[type] 482.68 KB 636.84 KB 181.95% (🔴 +29.07%)
/org/[orgSlug]/[user]/[type] 404.27 KB 558.44 KB 159.55% (🔴 +36.97%)
/org/[orgSlug]/[user]/[type]/embed 404.3 KB 558.46 KB 159.56% (🔴 +36.96%)
/org/[orgSlug]/team/[slug]/[type] 404.15 KB 558.32 KB 159.52% (🔴 +36.97%)
/settings/organizations/members 289.2 KB 443.36 KB 126.68% (🟢 -24.38%)
/team/[slug]/[type] 404.12 KB 558.28 KB 159.51% (🔴 +36.97%)
/team/[slug]/[type]/embed 404.15 KB 558.31 KB 159.52% (🔴 +36.97%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Copy Markdown
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✅ good first issue Good for newcomers Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ui area: UI, frontend, button, form, input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-2365] missing border-subtle for api keys

2 participants