fix: Italics not being shown in the description after saving#10848
Merged
pumfleet merged 3 commits intocalcom:mainfrom Aug 24, 2023
Merged
fix: Italics not being shown in the description after saving#10848pumfleet merged 3 commits intocalcom:mainfrom
pumfleet merged 3 commits intocalcom:mainfrom
Conversation
added 3 commits
August 19, 2023 00:56
…tsingh-22/cal.com into fix_event_description_formatting
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Someone is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thank you for following the naming conventions! 🙏 |
abhijeetsingh-22
changed the title
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Udit-takkar
approved these changes
Aug 23, 2023
Contributor
Udit-takkar
left a comment
Udit-takkar
left a comment
There was a problem hiding this comment.
LGTM. Tested works fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes the issue of Italic text not showing in the description of the event after saving the event.
The issue was caused due to the way Rich Text editor formats the HTML for the italic text. It wraps the italic text in the
<i>as well as<em>tag. And the HTML-to-makdown library that is being used was adding_twice making it bold rather than italic.Change Made
Added a rule in the turndownService (HTML-to-markdown) to ignore the
<em>tag. This prevents the double_Fixes #10828
Loom Video: Video Link
Type of change
How should this be tested?
Try creating a new event and in the description try making text Italic. It should work as intended. Earlier the italic text was being shown as bold text on saving the event.
Mandatory Tasks