Skip to content

chore: Reduced boilerplate for publicViewer router#10849

Merged
pumfleet merged 2 commits intomainfrom
chore/reduced-viewer-router-boilerplate
Aug 24, 2023
Merged

chore: Reduced boilerplate for publicViewer router#10849
pumfleet merged 2 commits intomainfrom
chore/reduced-viewer-router-boilerplate

Conversation

@zomars
Copy link
Copy Markdown
Contributor

@zomars zomars commented Aug 18, 2023

What does this PR do?

  • Reduces publicViewer boilerplate code
  • Uses importHandler instead
  • Adds default exports to handlers so it can be used easily with importHandler

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • yarn build
  • yarn test
  • yarn e2e

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 7:54pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 7:54pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 7:54pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 7:54pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2023 7:54pm
qa ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2023 7:54pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 18, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 18, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Aug 18, 2023

Current Playwright Test Results Summary

✅ 120 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/22/2023 07:58:37pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 222f6f7

Started: 08/22/2023 07:56:39pm UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1Initial Attempt
1.43% (4) 4 / 279 runs
failed over last 7 days
21.51% (60) 60 / 279 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
2.53% (7) 7 / 277 runs
failed over last 7 days
97.47% (270) 270 / 277 runs
flaked over last 7 days

View Detailed Build Results


@PeerRich PeerRich added Medium priority Created by Linear-GitHub Sync performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive i18n area: i18n, translations labels Aug 21, 2023
leog
leog previously approved these changes Aug 21, 2023
Copy link
Copy Markdown
Contributor

@leog leog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume the cache stuff that was removed does not mean any impact, it's just a different approach as far as I could understand. BTW @zomars there's a conflict.

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Aug 22, 2023

🤖 Meticulous spotted visual differences in 53 of 186 screens tested: view and approve differences detected.

Last updated for commit 222f6f7. This comment will update as new commits are pushed.

@pumfleet pumfleet merged commit 42cd565 into main Aug 24, 2023
@pumfleet pumfleet deleted the chore/reduced-viewer-router-boilerplate branch August 24, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only i18n area: i18n, translations Medium priority Created by Linear-GitHub Sync performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants