Skip to content

fix: Resolved Typescript Error in PR #9598 created by @vijeet-shah.#10871

Merged
PeerRich merged 7 commits into
calcom:mainfrom
pateldivyesh1323:9598
Aug 22, 2023
Merged

fix: Resolved Typescript Error in PR #9598 created by @vijeet-shah.#10871
PeerRich merged 7 commits into
calcom:mainfrom
pateldivyesh1323:9598

Conversation

@pateldivyesh1323
Copy link
Copy Markdown
Contributor

What does this PR do?

Error while testing the user onboarding locally. Can be replicated by creating a new user.
Removed the conditional assignment, the queryAvailability hook will always be used, ensuring that the availability data is consistently fetched and assigned to the availabilityForm.

Fixes #9539

Type of change

  • Bug fix (non-breaking change which fixes an issue)
    The issue was already solved by @vijeet-shah. Resolved Typescript Error in PR#9598.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 21, 2023

@pateldivyesh1323 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 10:52am

@github-actions github-actions Bot added Low priority Created by Linear-GitHub Sync ✅ good first issue Good for newcomers 🐛 bug Something isn't working labels Aug 21, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 21, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 21, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@pateldivyesh1323
Copy link
Copy Markdown
Contributor Author

@keithwillcode Can You Please review this. I have solved the type error created in pr #9598 which solved issue #9539

Comment thread apps/web/components/getting-started/steps-views/SetupAvailability.tsx Outdated
Comment thread apps/web/components/getting-started/steps-views/SetupAvailability.tsx Outdated
@Udit-takkar
Copy link
Copy Markdown
Contributor

@pateldivyesh1323 format using prettier and resolve the conflicts

vijeet-shah and others added 5 commits August 22, 2023 13:22
…ity.tsx

Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
@pateldivyesh1323
Copy link
Copy Markdown
Contributor Author

@Udit-takkar I think you need to give approval

@PeerRich PeerRich merged commit f393fd4 into calcom:main Aug 22, 2023
@pateldivyesh1323
Copy link
Copy Markdown
Contributor Author

Thankyou everyone for help.This was my first PR

@pateldivyesh1323 pateldivyesh1323 deleted the 9598 branch August 22, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working ✅ good first issue Good for newcomers Low priority Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-1955] Possible conditional hook usage issue

4 participants