Skip to content

fix: client locale inference#10893

Merged
keithwillcode merged 16 commits into
mainfrom
fix/client-locale-inference
Aug 22, 2023
Merged

fix: client locale inference#10893
keithwillcode merged 16 commits into
mainfrom
fix/client-locale-inference

Conversation

@zomars
Copy link
Copy Markdown
Contributor

@zomars zomars commented Aug 22, 2023

What does this PR do?

followup to #10850

Fixes an issue where requesting locale "es" would respond with "es-419" instead of "es".

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Changing your language to Spanish in settings should behave as expected

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 5:50pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 5:50pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 5:50pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 5:50pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Aug 22, 2023 5:50pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 22, 2023

Thank you for following the naming conventions! 🙏

@zomars zomars added the core area: core, team members only label Aug 22, 2023
@socket-security
Copy link
Copy Markdown

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
bcp-47-match 2.0.3 None +0 19.5 kB wooorm

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Aug 22, 2023

🤖 Meticulous spotted visual differences in 54 of 179 screens tested: view and approve differences detected.

Last updated for commit dc2c06c. This comment will update as new commits are pushed.

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Aug 22, 2023

Current Playwright Test Results Summary

✅ 120 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/22/2023 05:54:07pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: dc2c06c

Started: 08/22/2023 05:51:32pm UTC

⚠️ Flakes

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 2Retry 1Initial Attempt
1.47% (4) 4 / 272 runs
failed over last 7 days
6.62% (18) 18 / 272 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
2.57% (7) 7 / 272 runs
failed over last 7 days
97.43% (265) 265 / 272 runs
flaked over last 7 days

📄   packages/app-store/typeform/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1Initial Attempt
0% (0) 0 / 276 runs
failed over last 7 days
3.26% (9) 9 / 276 runs
flaked over last 7 days

View Detailed Build Results


@@ -1,4 +1,4 @@
import parser from "accept-language-parser";
import { lookup } from "bcp-47-match";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just 645 bytes after tree shaking @hariombalhara

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

@keithwillcode keithwillcode merged commit c4b9a9e into main Aug 22, 2023
@keithwillcode keithwillcode deleted the fix/client-locale-inference branch August 22, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants