perf: Remove non booker apps from booker page#10905
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
Thank you for following the naming conventions! 🙏 |
hariombalhara
force-pushed
the
perf/booking-bundle-only-booker-apps
branch
2 times, most recently
from
404d95b to
716cfd3
Compare
| }); | ||
|
|
||
| function forEachAppDir(callback: (arg: App) => void) { | ||
| function forEachAppDir(callback: (arg: App) => void, filter: (arg: App) => boolean = () => true) { |
There was a problem hiding this comment.
filter support to allow us to do things for apps statisfying a certain condition
hariombalhara
changed the title
hariombalhara
force-pushed
the
perf/booking-bundle-only-booker-apps
branch
from
716cfd3 to
85e04d3
Compare
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Sixty-seven Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 120 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/24/2023 07:54:03am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: fcf3e9e Started: 08/24/2023 07:51:05am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
2.49% (6)6 / 241 runsfailed over last 7 days |
97.10% (234)234 / 241 runsflaked over last 7 days |
hariombalhara
force-pushed
the
perf/booking-bundle-only-booker-apps
branch
from
8add9bb to
fcf3e9e
Compare
| app = JSON.parse(fs.readFileSync(configPath).toString()); | ||
| } else if (fs.existsSync(metadataPath)) { | ||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | ||
| app = require(metadataPath).metadata; |
There was a problem hiding this comment.
Earlier we weren't reading old _metadata files for app details. It wasn't needed but it is needed now(Zoom is such an app and we need to have appData.location set on it) and it makes more sense to do it.
2 participants
What does this PR do?
Creates a separate
bookerApps.metadata.generated.tsmodule to load only those app's config that we need on booker page.It reduces bundle size(though not that significant improvemen. But more importantly, it ensures that any new app's config won't be added to booker bundle unless it's needed there
Fixes #7276
Type of change
How should this be tested?
Mandatory Tasks
Checklist