Skip to content

fix: Prevents mixed server and client code#10909

Merged
zomars merged 1 commit into
mainfrom
fix/mixed-server-client-code
Aug 23, 2023
Merged

fix: Prevents mixed server and client code#10909
zomars merged 1 commit into
mainfrom
fix/mixed-server-client-code

Conversation

@zomars
Copy link
Copy Markdown
Contributor

@zomars zomars commented Aug 23, 2023

What does this PR do?

Fixes an issue with server/client code mixup

image

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 4:20pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 4:20pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 4:20pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 4:20pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Aug 23, 2023 4:20pm
qa ⬜️ Ignored (Inspect) Aug 23, 2023 4:20pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 23, 2023

Thank you for following the naming conventions! 🙏

@zomars zomars added the core area: core, team members only label Aug 23, 2023
@zomars zomars requested a review from a team August 23, 2023 16:14
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Aug 23, 2023

Current Playwright Test Results Summary

✅ 120 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/23/2023 04:24:54pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 8d9220d

Started: 08/23/2023 04:21:02pm UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
2.70% (7) 7 / 259 runs
failed over last 7 days
96.91% (251) 251 / 259 runs
flaked over last 7 days

View Detailed Build Results


@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/settings/admin/users/[id]/edit 339.05 KB 494.37 KB 141.25% (🟢 -13.11%)
/settings/admin/users/add 338.78 KB 494.1 KB 141.17% (🟢 -13.09%)
/settings/my-account/general 336.28 KB 491.6 KB 140.46% (🟢 -12.92%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@zomars zomars merged commit bc7da56 into main Aug 23, 2023
@zomars zomars deleted the fix/mixed-server-client-code branch August 23, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants