fix: Remove multiple durations for seated events#10910
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
joeauyeung
commented
Aug 23, 2023
| }, | ||
| })), | ||
| multipleDurationEnabled: eventType.metadata?.multipleDuration || false, | ||
| seatsPerTimeSlotEnabled: eventType.seatsPerTimeSlot, |
Contributor
Author
There was a problem hiding this comment.
Enable this default value as you had to navigate to the "Advanced" tab for this value to appear
| toggleGuests(false); | ||
| formMethods.setValue("requiresConfirmation", false); | ||
| setRequiresConfirmation(false); | ||
| formMethods.setValue("metadata.multipleDuration", undefined); |
Contributor
Author
There was a problem hiding this comment.
Remove all multiple durations when seats are enabled
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 120 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/23/2023 06:25:00pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: f095253 Started: 08/23/2023 06:12:08pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
1.51% (4)4 / 265 runsfailed over last 7 days |
23.40% (62)62 / 265 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
2.65% (7)7 / 264 runsfailed over last 7 days |
96.97% (256)256 / 264 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
FORM_SUBMITTED can submit a form and get a submission event
Retry 1 • Initial Attempt |
1.15% (3)3 / 261 runsfailed over last 7 days |
21.46% (56)56 / 261 runsflaked over last 7 days |
leog
previously approved these changes
Aug 23, 2023
Contributor
leog
left a comment
leog
left a comment
There was a problem hiding this comment.
LGTM, any test to update for this?
keithwillcode
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR disables multiple durations for seated events.
Fixes # (issue)
Requirement/Documentation
Type of change
How should this be tested?
Mandatory Tasks
Checklist