Skip to content

fix: adding a new workflow step that requires kyc verification#10912

Merged
keithwillcode merged 2 commits into
mainfrom
fix/kyc-verification-added-step
Aug 23, 2023
Merged

fix: adding a new workflow step that requires kyc verification#10912
keithwillcode merged 2 commits into
mainfrom
fix/kyc-verification-added-step

Conversation

@CarinaWolli
Copy link
Copy Markdown
Member

What does this PR do?

Fixes that a verified user could not add a new step with 'sms to attendee'. It was throwing UNAUTHORIZED 'Account needs to be verified'.

Also, added verify badge to the actions dropdown in the 'Add Action' Modal.

Before:
Screenshot 2023-08-23 at 13 54 01

After:
Screenshot 2023-08-23 at 13 53 12

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Create a new workflow with a KYC verified user
  • Add new action 'send SMS to attendee + add template text
  • Save workflow
  • See that workflow is successfully saved

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 6:01pm
cal-demo ✅ Ready (Inspect) Visit Preview Aug 23, 2023 6:01pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 6:01pm
ui ✅ Ready (Inspect) Visit Preview Aug 23, 2023 6:01pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Aug 23, 2023 6:01pm

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@zomars zomars added the core area: core, team members only label Aug 23, 2023
@CarinaWolli CarinaWolli requested a review from a team August 23, 2023 18:08
@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Aug 23, 2023

Current Playwright Test Results Summary

✅ 120 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/23/2023 06:23:08pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 460b7cf

Started: 08/23/2023 06:08:31pm UTC

⚠️ Flakes

📄   packages/app-store/typeform/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1Initial Attempt
1.86% (5) 5 / 269 runs
failed over last 7 days
10.78% (29) 29 / 269 runs
flaked over last 7 days

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 2Retry 1Initial Attempt
1.51% (4) 4 / 265 runs
failed over last 7 days
23.40% (62) 62 / 265 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
2.65% (7) 7 / 264 runs
failed over last 7 days
96.97% (256) 256 / 264 runs
flaked over last 7 days

View Detailed Build Results


@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@keithwillcode keithwillcode merged commit b238221 into main Aug 23, 2023
@keithwillcode keithwillcode deleted the fix/kyc-verification-added-step branch August 23, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants