fix: phoneSchema missing async parsing#10929
Merged
kodiakhq[bot] merged 2 commits intomainfrom Aug 24, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
Udit-takkar
changed the title
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
hariombalhara
commented
Aug 24, 2023
| // `typeOfOptionInput` can be any of the main types. So, we the same validations should run for `optionValue` | ||
| if (typeOfOptionInput === "phone") { | ||
| if (!phoneSchema.safeParse(optionValue).success) { | ||
| if (!(await phoneSchema.safeParseAsync(optionValue)).success) { |
Member
Author
There was a problem hiding this comment.
There was one occurrence earlier in the code for phoneSchema that has been handled. That triggered when a Phone number type field is chosen but this one is special location field handling.
Current Playwright Test Results Summary✅ 120 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/24/2023 12:42:58pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 79d9530 Started: 08/24/2023 12:41:06pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Manage Booking Questions For Team EventType Do a booking with a user added question and verify a few thing in b/w
Retry 1 • Initial Attempt |
1.17% (3)3 / 256 runsfailed over last 7 days |
0.78% (2)2 / 256 runsflaked over last 7 days |
📄 packages/app-store/typeform/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Typeform App Typeform Redirect Link should copy link in editing area
Retry 1 • Initial Attempt |
0% (0)0 / 262 runsfailed over last 7 days |
1.53% (4)4 / 262 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
FORM_SUBMITTED can submit a form and get a submission event
Retry 1 • Initial Attempt |
1.17% (3)3 / 257 runsfailed over last 7 days |
23.35% (60)60 / 257 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
2.33% (6)6 / 258 runsfailed over last 7 days |
97.29% (251)251 / 258 runsflaked over last 7 days |
This was referenced Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes broken booking form if attendee phone number is chosen.
Demo that it works now
Type of change
How should this be tested?
Checklist