Skip to content

fix: allows patching booking and period limits from API#10935

Merged
zomars merged 4 commits intomainfrom
fix/api-booking-and-period-limits
Aug 25, 2023
Merged

fix: allows patching booking and period limits from API#10935
zomars merged 4 commits intomainfrom
fix/api-booking-and-period-limits

Conversation

@zomars
Copy link
Copy Markdown
Contributor

@zomars zomars commented Aug 24, 2023

What does this PR do?

  • As requested by an Enterprise customer (cc @shirazdole), Allows updating booking limits and period limits from API

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 8:26pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 8:26pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 8:26pm
ui ❌ Failed (Inspect) Aug 24, 2023 8:26pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Aug 24, 2023 8:26pm
qa ⬜️ Ignored (Inspect) Visit Preview Aug 24, 2023 8:26pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 24, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 24, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Aug 24, 2023

Current Playwright Test Results Summary

✅ 120 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/24/2023 08:31:59pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 57711f9

Started: 08/24/2023 08:30:26pm UTC

⚠️ Flakes

📄   apps/web/playwright/reschedule.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule Tests Should do a reschedule from user owner
Retry 1Initial Attempt
1.50% (4) 4 / 267 runs
failed over last 7 days
1.12% (3) 3 / 267 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
2.21% (6) 6 / 272 runs
failed over last 7 days
97.43% (265) 265 / 272 runs
flaked over last 7 days

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
pro user can reschedule a booking
Retry 1Initial Attempt
1.11% (3) 3 / 271 runs
failed over last 7 days
9.23% (25) 25 / 271 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!, nice.

@zomars zomars merged commit 6ce4122 into main Aug 25, 2023
@zomars zomars deleted the fix/api-booking-and-period-limits branch August 25, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants