fix: DataTable storybook file is not rendering#10984
Merged
sean-brydon merged 2 commits intomainfrom Sep 6, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 122 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/01/2023 10:05:14pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 3ef9dec Started: 09/01/2023 10:02:59pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt |
0.36% (1)1 / 276 runfailed over last 7 days |
30.07% (83)83 / 276 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Pending payment booking should not be confirmed by default
Retry 1 • Initial Attempt |
5.70% (17)17 / 298 runsfailed over last 7 days |
7.05% (21)21 / 298 runsflaked over last 7 days |
|
Stripe integration When event is paid and confirmed Cancelled paid booking should be refunded
Retry 1 • Initial Attempt |
0.37% (1)1 / 270 runfailed over last 7 days |
8.52% (23)23 / 270 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
5.47% (17)17 / 311 runsfailed over last 7 days |
93.89% (292)292 / 311 runsflaked over last 7 days |
sean-brydon
approved these changes
Sep 6, 2023
Member
sean-brydon
left a comment
sean-brydon
left a comment
There was a problem hiding this comment.
This is perfect! Thank you for also adding the controls :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DataTablecomponent that was not being rendered.DataTable.Video/Screenshot Demo
Issue Demonstration:
Fix:
https://www.loom.com/share/488758ae2aab4432bfc26f2ed9a51885?sid=09a838dc-5f43-4f32-b0fc-034278e2a06f