Skip to content

fix: Routing Form - Show responses in the order of fields#11143

Merged
CarinaWolli merged 3 commits intomainfrom
improvements/ordered-responses
Sep 7, 2023
Merged

fix: Routing Form - Show responses in the order of fields#11143
CarinaWolli merged 3 commits intomainfrom
improvements/ordered-responses

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Sep 5, 2023

What does this PR do?

Fixes #11146

Before: https://www.loom.com/share/05bcdf1518844b21901cf57496cbf9b6
After: https://www.loom.com/share/137fc7b0664a4f9a898800b95b83b43a

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Are there environment variables that should be set? No
  • What are the minimal test data to have? Create a Routing Form with 3-4 fields.
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR - Make sure to enable 'Send Email to Owner' toggle for the form

How should this be tested?

  • Create a Routing Form with 3-4 fields. Submit it and observe the order of responses in the email that you get.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@hariombalhara hariombalhara force-pushed the improvements/ordered-responses branch from 7f51a26 to 9037a57 Compare September 5, 2023 06:42
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ❌ Failed (Inspect) Sep 7, 2023 3:20pm
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 3:20pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 3:20pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 3:20pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 3:20pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 7, 2023 3:20pm
qa ⬜️ Ignored (Inspect) Visit Preview Sep 7, 2023 3:20pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 5, 2023

Thank you for following the naming conventions! 🙏

@zomars zomars added the core area: core, team members only label Sep 5, 2023
@hariombalhara hariombalhara changed the title Revert "feat: adds next cold start profiler (#11014)" improvement: Show routing form responses in the order of fields Sep 5, 2023
@hariombalhara hariombalhara changed the title improvement: Show routing form responses in the order of fields improvement: Show routing form Email Responses in the order of fields Sep 5, 2023
@hariombalhara hariombalhara force-pushed the improvements/ordered-responses branch from 9037a57 to 0d561ef Compare September 5, 2023 06:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 5, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link
Copy Markdown

deploysentinel Bot commented Sep 5, 2023

Current Playwright Test Results Summary

✅ 117 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/07/2023 03:21:52pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 82b6fa1

Started: 09/07/2023 03:20:06pm UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
2.30% (7) 7 / 304 runs
failed over last 7 days
96.38% (293) 293 / 304 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 1Initial Attempt
0% (0) 0 / 100 runs
failed over last 7 days
11% (11) 11 / 100 runs
flaked over last 7 days

View Detailed Build Results


@hariombalhara hariombalhara changed the title improvement: Show routing form Email Responses in the order of fields fix: Routing Form - Show responses in the order of fields Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Responses are unordered in Routing form email

3 participants