Skip to content

fix: event duration can be 0#11145

Merged
PeerRich merged 2 commits intocalcom:mainfrom
MehulZR:fix_event_duration
Sep 6, 2023
Merged

fix: event duration can be 0#11145
PeerRich merged 2 commits intocalcom:mainfrom
MehulZR:fix_event_duration

Conversation

@MehulZR
Copy link
Copy Markdown
Contributor

@MehulZR MehulZR commented Sep 5, 2023

What does this PR do?

Fixes: It is possible to book a event with length of 0. This is possible when saving the form from a tab other than the Event Setup.

image

fix.mp4

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 0:34am

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 5, 2023

@MehulZR is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 5, 2023

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 5, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Comment thread apps/web/public/static/locales/en/common.json Outdated
Comment thread packages/trpc/server/routers/viewer/eventTypes/update.handler.ts Outdated
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeerRich PeerRich merged commit bf437b7 into calcom:main Sep 6, 2023
@MehulZR MehulZR deleted the fix_event_duration branch October 9, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants